Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] clk: sunxi-ng: sun5i: Add clk_set_rate_parent to the CPU clock
@ 2017-07-21 16:19 Maxime Ripard
  2017-07-22  2:23 ` Chen-Yu Tsai
  0 siblings, 1 reply; 3+ messages in thread
From: Maxime Ripard @ 2017-07-21 16:19 UTC (permalink / raw)
  To: linux-arm-kernel

The current CPU clock is missing the option to change the rate of its
parents, leading to improper rates calculated by cpufreq, and eventually
crashes.

Cc: <stable@vger.kernel.org>
Fixes: 5e73761786d6 ("clk: sunxi-ng: Add sun5i CCU driver")
Reported-by: Kevin Hilman <khilman@baylibre.com>
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
 drivers/clk/sunxi-ng/ccu-sun5i.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/sunxi-ng/ccu-sun5i.c b/drivers/clk/sunxi-ng/ccu-sun5i.c
index 5372bf8be5e6..31d7ffda9aab 100644
--- a/drivers/clk/sunxi-ng/ccu-sun5i.c
+++ b/drivers/clk/sunxi-ng/ccu-sun5i.c
@@ -184,7 +184,7 @@ static struct ccu_mux cpu_clk = {
 		.hw.init	= CLK_HW_INIT_PARENTS("cpu",
 						      cpu_parents,
 						      &ccu_mux_ops,
-						      CLK_IS_CRITICAL),
+						      CLK_SET_RATE_PARENT | CLK_IS_CRITICAL),
 	}
 };
 
-- 
2.13.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] clk: sunxi-ng: sun5i: Add clk_set_rate_parent to the CPU clock
  2017-07-21 16:19 [PATCH] clk: sunxi-ng: sun5i: Add clk_set_rate_parent to the CPU clock Maxime Ripard
@ 2017-07-22  2:23 ` Chen-Yu Tsai
  2017-07-24  9:37   ` Maxime Ripard
  0 siblings, 1 reply; 3+ messages in thread
From: Chen-Yu Tsai @ 2017-07-22  2:23 UTC (permalink / raw)
  To: linux-arm-kernel

On Sat, Jul 22, 2017 at 12:19 AM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> The current CPU clock is missing the option to change the rate of its
> parents, leading to improper rates calculated by cpufreq, and eventually
> crashes.
>
> Cc: <stable@vger.kernel.org>
> Fixes: 5e73761786d6 ("clk: sunxi-ng: Add sun5i CCU driver")
> Reported-by: Kevin Hilman <khilman@baylibre.com>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Acked-by: Chen-Yu Tsai <wens@csie.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] clk: sunxi-ng: sun5i: Add clk_set_rate_parent to the CPU clock
  2017-07-22  2:23 ` Chen-Yu Tsai
@ 2017-07-24  9:37   ` Maxime Ripard
  0 siblings, 0 replies; 3+ messages in thread
From: Maxime Ripard @ 2017-07-24  9:37 UTC (permalink / raw)
  To: linux-arm-kernel

On Sat, Jul 22, 2017 at 10:23:19AM +0800, Chen-Yu Tsai wrote:
> On Sat, Jul 22, 2017 at 12:19 AM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > The current CPU clock is missing the option to change the rate of its
> > parents, leading to improper rates calculated by cpufreq, and eventually
> > crashes.
> >
> > Cc: <stable@vger.kernel.org>
> > Fixes: 5e73761786d6 ("clk: sunxi-ng: Add sun5i CCU driver")
> > Reported-by: Kevin Hilman <khilman@baylibre.com>
> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> 
> Acked-by: Chen-Yu Tsai <wens@csie.org>

Applied as a fix, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170724/c1e72a42/attachment.sig>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-07-24  9:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-21 16:19 [PATCH] clk: sunxi-ng: sun5i: Add clk_set_rate_parent to the CPU clock Maxime Ripard
2017-07-22  2:23 ` Chen-Yu Tsai
2017-07-24  9:37   ` Maxime Ripard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox