From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 07/10] mfd: axp20x: add pinctrl cell for AXP813
Date: Thu, 28 Sep 2017 20:06:14 +0100 [thread overview]
Message-ID: <20170928190614.v5jgejvgdlyxbxrh@dell> (raw)
In-Reply-To: <20170926131445.xo2uawiovjtmyivj@flea>
On Tue, 26 Sep 2017, Maxime Ripard wrote:
> On Tue, Sep 26, 2017 at 12:17:17PM +0000, Quentin Schulz wrote:
> > As pinctrl and GPIO driver now supports AXP813, add a cell for it.
> >
> > Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>
> > ---
> > drivers/mfd/axp20x.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> > index 336de66..a457528 100644
> > --- a/drivers/mfd/axp20x.c
> > +++ b/drivers/mfd/axp20x.c
> > @@ -876,6 +876,9 @@ static struct mfd_cell axp813_cells[] = {
> > .name = "axp221-pek",
> > .num_resources = ARRAY_SIZE(axp803_pek_resources),
> > .resources = axp803_pek_resources,
> > + }, {
> > + .name = "axp20x-gpio",
> > + .of_compatible = "x-powers,axp813-pctl",
>
> This was probably introduced in the previous driver, but why are you
> using the pctl suffix? Can't we just use the GPIO one to remain
> consistent with the previous users and the datasheet?
Right. Pinctrl is a Linuxisum. GPIO sounds more appropriate.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-09-28 19:06 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 12:17 [PATCH v2 00/10] add pinmuxing support for pins in AXP209 and AXP813 PMICs Quentin Schulz
2017-09-26 12:17 ` [PATCH v2 01/10] pinctrl: move gpio-axp209 to pinctrl Quentin Schulz
2017-09-26 12:55 ` Maxime Ripard
2017-09-26 12:59 ` Quentin Schulz
2017-09-26 13:08 ` Chen-Yu Tsai
2017-10-05 20:50 ` Rob Herring
2017-09-26 12:17 ` [PATCH v2 02/10] pinctrl: axp209: add pinctrl features Quentin Schulz
2017-09-26 13:00 ` Maxime Ripard
2017-09-26 13:08 ` Quentin Schulz
2017-09-26 13:27 ` Maxime Ripard
2017-09-26 13:37 ` Quentin Schulz
2017-09-27 9:28 ` Maxime Ripard
2017-09-26 12:17 ` [PATCH v2 03/10] pinctrl: axp209: use drv_data of pinctrl_pin_desc to store pin reg Quentin Schulz
2017-09-26 13:01 ` Maxime Ripard
2017-09-26 13:17 ` Quentin Schulz
2017-09-26 13:45 ` Maxime Ripard
2017-09-29 17:27 ` kbuild test robot
2017-09-26 12:17 ` [PATCH v2 04/10] pinctrl: axp209: rename everything from gpio to pctl Quentin Schulz
2017-09-26 12:17 ` [PATCH v2 05/10] pinctrl: axp209: add programmable gpio_status_offset Quentin Schulz
2017-09-26 12:17 ` [PATCH v2 06/10] pinctrl: axp209: add support for AXP813 GPIOs Quentin Schulz
2017-09-26 13:12 ` Maxime Ripard
2017-09-26 12:17 ` [PATCH v2 07/10] mfd: axp20x: add pinctrl cell for AXP813 Quentin Schulz
2017-09-26 13:14 ` Maxime Ripard
2017-09-28 19:06 ` Lee Jones [this message]
2017-09-26 12:17 ` [PATCH v2 08/10] ARM: dts: add dtsi for AXP813 PMIC Quentin Schulz
2017-09-26 13:16 ` Maxime Ripard
2017-09-26 13:53 ` Chen-Yu Tsai
2017-09-26 12:17 ` [PATCH v2 09/10] ARM: dts: sun8i: a711: include axp813 dtsi Quentin Schulz
2017-09-26 12:17 ` [PATCH v2 10/10] ARM: dts: sun8i: bananapi-m3: " Quentin Schulz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170928190614.v5jgejvgdlyxbxrh@dell \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox