From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 01/10] pinctrl: move gpio-axp209 to pinctrl
Date: Thu, 5 Oct 2017 15:50:37 -0500 [thread overview]
Message-ID: <20171005205037.hxtoyeryiolflkda@rob-hp-laptop> (raw)
In-Reply-To: <e193f8efe9092171ebeffb77ab77422179fd3cab.1506428208.git-series.quentin.schulz@free-electrons.com>
On Tue, Sep 26, 2017 at 02:17:11PM +0200, Quentin Schulz wrote:
> To prepare the driver for the upcoming pinctrl features, move the GPIO
> driver AXP209 from GPIO to pinctrl subsystem.
>
> Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>
> ---
> Documentation/devicetree/bindings/gpio/gpio-axp209.txt | 30 +-
> Documentation/devicetree/bindings/pinctrl/pinctrl-axp209.txt | 30 +-
> drivers/gpio/Kconfig | 6 +-
> drivers/gpio/Makefile | 1 +-
> drivers/gpio/gpio-axp209.c | 188 +-------
> drivers/pinctrl/Kconfig | 6 +-
> drivers/pinctrl/Makefile | 1 +-
> drivers/pinctrl/pinctrl-axp209.c | 188 +++++++-
> 8 files changed, 225 insertions(+), 225 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-axp209.txt
> create mode 100644 Documentation/devicetree/bindings/pinctrl/pinctrl-axp209.txt
> delete mode 100644 drivers/gpio/gpio-axp209.c
> create mode 100644 drivers/pinctrl/pinctrl-axp209.c
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-axp209.txt b/Documentation/devicetree/bindings/gpio/gpio-axp209.txt
> deleted file mode 100644
> index a661130..0000000
> --- a/Documentation/devicetree/bindings/gpio/gpio-axp209.txt
> +++ /dev/null
> @@ -1,30 +0,0 @@
> -AXP209 GPIO controller
> -
> -This driver follows the usual GPIO bindings found in
> -Documentation/devicetree/bindings/gpio/gpio.txt
> -
> -Required properties:
> -- compatible: Should be "x-powers,axp209-gpio"
> -- #gpio-cells: Should be two. The first cell is the pin number and the
> - second is the GPIO flags.
> -- gpio-controller: Marks the device node as a GPIO controller.
> -
> -This node must be a subnode of the axp20x PMIC, documented in
> -Documentation/devicetree/bindings/mfd/axp20x.txt
> -
> -Example:
> -
> -axp209: pmic at 34 {
> - compatible = "x-powers,axp209";
> - reg = <0x34>;
> - interrupt-parent = <&nmi_intc>;
> - interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> - interrupt-controller;
> - #interrupt-cells = <1>;
> -
> - axp_gpio: gpio {
> - compatible = "x-powers,axp209-gpio";
> - gpio-controller;
> - #gpio-cells = <2>;
> - };
> -};
> diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-axp209.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-axp209.txt
> new file mode 100644
> index 0000000..a661130
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-axp209.txt
> @@ -0,0 +1,30 @@
> +AXP209 GPIO controller
> +
> +This driver follows the usual GPIO bindings found in
> +Documentation/devicetree/bindings/gpio/gpio.txt
> +
> +Required properties:
> +- compatible: Should be "x-powers,axp209-gpio"
> +- #gpio-cells: Should be two. The first cell is the pin number and the
> + second is the GPIO flags.
> +- gpio-controller: Marks the device node as a GPIO controller.
Maybe there's some reason to move the driver, but the binding describes
a gpio-controller so it should remain in bindings/gpio/. Binding and
driver directories aren't one to one necessarily.
Rob
next prev parent reply other threads:[~2017-10-05 20:50 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 12:17 [PATCH v2 00/10] add pinmuxing support for pins in AXP209 and AXP813 PMICs Quentin Schulz
2017-09-26 12:17 ` [PATCH v2 01/10] pinctrl: move gpio-axp209 to pinctrl Quentin Schulz
2017-09-26 12:55 ` Maxime Ripard
2017-09-26 12:59 ` Quentin Schulz
2017-09-26 13:08 ` Chen-Yu Tsai
2017-10-05 20:50 ` Rob Herring [this message]
2017-09-26 12:17 ` [PATCH v2 02/10] pinctrl: axp209: add pinctrl features Quentin Schulz
2017-09-26 13:00 ` Maxime Ripard
2017-09-26 13:08 ` Quentin Schulz
2017-09-26 13:27 ` Maxime Ripard
2017-09-26 13:37 ` Quentin Schulz
2017-09-27 9:28 ` Maxime Ripard
2017-09-26 12:17 ` [PATCH v2 03/10] pinctrl: axp209: use drv_data of pinctrl_pin_desc to store pin reg Quentin Schulz
2017-09-26 13:01 ` Maxime Ripard
2017-09-26 13:17 ` Quentin Schulz
2017-09-26 13:45 ` Maxime Ripard
2017-09-29 17:27 ` kbuild test robot
2017-09-26 12:17 ` [PATCH v2 04/10] pinctrl: axp209: rename everything from gpio to pctl Quentin Schulz
2017-09-26 12:17 ` [PATCH v2 05/10] pinctrl: axp209: add programmable gpio_status_offset Quentin Schulz
2017-09-26 12:17 ` [PATCH v2 06/10] pinctrl: axp209: add support for AXP813 GPIOs Quentin Schulz
2017-09-26 13:12 ` Maxime Ripard
2017-09-26 12:17 ` [PATCH v2 07/10] mfd: axp20x: add pinctrl cell for AXP813 Quentin Schulz
2017-09-26 13:14 ` Maxime Ripard
2017-09-28 19:06 ` Lee Jones
2017-09-26 12:17 ` [PATCH v2 08/10] ARM: dts: add dtsi for AXP813 PMIC Quentin Schulz
2017-09-26 13:16 ` Maxime Ripard
2017-09-26 13:53 ` Chen-Yu Tsai
2017-09-26 12:17 ` [PATCH v2 09/10] ARM: dts: sun8i: a711: include axp813 dtsi Quentin Schulz
2017-09-26 12:17 ` [PATCH v2 10/10] ARM: dts: sun8i: bananapi-m3: " Quentin Schulz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171005205037.hxtoyeryiolflkda@rob-hp-laptop \
--to=robh@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox