* [PATCH 1/2] ARM: dts: imx6: RDU2: disable internal watchdog
@ 2017-12-27 3:56 Andrey Smirnov
2017-12-27 3:56 ` [PATCH 2/2] ARM: dts: imx6: RDU2: correct RTC compatible Andrey Smirnov
2017-12-27 11:09 ` [PATCH 1/2] ARM: dts: imx6: RDU2: disable internal watchdog Fabio Estevam
0 siblings, 2 replies; 6+ messages in thread
From: Andrey Smirnov @ 2017-12-27 3:56 UTC (permalink / raw)
To: linux-arm-kernel
The system has an external watchdog in the environment processor
so the internal watchdog is of no use.
Cc: Sascha Hauer <kernel@pengutronix.de>
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: linux-arm-kernel at lists.infradead.org
Cc: devicetree at vger.kernel.org
Cc: linux-kernel at vger.kernel.org
Cc: cphealy at gmail.com
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
index 6bef9a98678e..818bfc8692a5 100644
--- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
@@ -838,6 +838,10 @@
status = "okay";
};
+&wdog1 {
+ status = "disabled";
+};
+
&audmux {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_audmux>;
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] ARM: dts: imx6: RDU2: correct RTC compatible
2017-12-27 3:56 [PATCH 1/2] ARM: dts: imx6: RDU2: disable internal watchdog Andrey Smirnov
@ 2017-12-27 3:56 ` Andrey Smirnov
2017-12-27 11:11 ` Fabio Estevam
2017-12-27 11:09 ` [PATCH 1/2] ARM: dts: imx6: RDU2: disable internal watchdog Fabio Estevam
1 sibling, 1 reply; 6+ messages in thread
From: Andrey Smirnov @ 2017-12-27 3:56 UTC (permalink / raw)
To: linux-arm-kernel
The RTC is manufactured by Maxim. This is a cosmetic fix, as Linux
doesn't match the vendor string for i2c devices.
Cc: Sascha Hauer <kernel@pengutronix.de>
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: linux-arm-kernel at lists.infradead.org
Cc: devicetree at vger.kernel.org
Cc: linux-kernel at vger.kernel.org
Cc: cphealy at gmail.com
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
index eef737bd52d9..6bef9a98678e 100644
--- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
@@ -581,7 +581,7 @@
};
ds1341: rtc at 68 {
- compatible = "dallas,ds1341";
+ compatible = "maxim,ds1341";
reg = <0x68>;
};
};
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] ARM: dts: imx6: RDU2: correct RTC compatible
2017-12-27 3:56 ` [PATCH 2/2] ARM: dts: imx6: RDU2: correct RTC compatible Andrey Smirnov
@ 2017-12-27 11:11 ` Fabio Estevam
2017-12-27 19:33 ` Andrey Smirnov
0 siblings, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2017-12-27 11:11 UTC (permalink / raw)
To: linux-arm-kernel
Hi Andrey,
On Wed, Dec 27, 2017 at 1:56 AM, Andrey Smirnov
<andrew.smirnov@gmail.com> wrote:
> The RTC is manufactured by Maxim. This is a cosmetic fix, as Linux
> doesn't match the vendor string for i2c devices.
>
> Cc: Sascha Hauer <kernel@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: devicetree at vger.kernel.org
> Cc: linux-kernel at vger.kernel.org
> Cc: cphealy at gmail.com
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
This patch seems to be from Lucas:
https://patchwork.kernel.org/patch/10099397/
,so his name should appear in the From field.
Anyway, this patch has been sent earlier and we suggested to keep the
existing binding, which is the documented form:
https://patchwork.kernel.org/patch/10099397/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] ARM: dts: imx6: RDU2: correct RTC compatible
2017-12-27 11:11 ` Fabio Estevam
@ 2017-12-27 19:33 ` Andrey Smirnov
0 siblings, 0 replies; 6+ messages in thread
From: Andrey Smirnov @ 2017-12-27 19:33 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Dec 27, 2017 at 3:11 AM, Fabio Estevam <festevam@gmail.com> wrote:
> Hi Andrey,
>
> On Wed, Dec 27, 2017 at 1:56 AM, Andrey Smirnov
> <andrew.smirnov@gmail.com> wrote:
>> The RTC is manufactured by Maxim. This is a cosmetic fix, as Linux
>> doesn't match the vendor string for i2c devices.
>>
>> Cc: Sascha Hauer <kernel@pengutronix.de>
>> Cc: Fabio Estevam <fabio.estevam@nxp.com>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Cc: Mark Rutland <mark.rutland@arm.com>
>> Cc: linux-arm-kernel at lists.infradead.org
>> Cc: devicetree at vger.kernel.org
>> Cc: linux-kernel at vger.kernel.org
>> Cc: cphealy at gmail.com
>> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
>> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
>
> This patch seems to be from Lucas:
> https://patchwork.kernel.org/patch/10099397/
>
> ,so his name should appear in the From field.
>
> Anyway, this patch has been sent earlier and we suggested to keep the
> existing binding, which is the documented form:
> https://patchwork.kernel.org/patch/10099397/
Yes, the patch is from Lucas and I was just being a messenger. And
understood and thanks for the info.
Sorry for the noise and disregard this patch.
Thanks,
Andrey Smirnov
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] ARM: dts: imx6: RDU2: disable internal watchdog
2017-12-27 3:56 [PATCH 1/2] ARM: dts: imx6: RDU2: disable internal watchdog Andrey Smirnov
2017-12-27 3:56 ` [PATCH 2/2] ARM: dts: imx6: RDU2: correct RTC compatible Andrey Smirnov
@ 2017-12-27 11:09 ` Fabio Estevam
2017-12-27 19:30 ` Andrey Smirnov
1 sibling, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2017-12-27 11:09 UTC (permalink / raw)
To: linux-arm-kernel
Hi Andrey,
On Wed, Dec 27, 2017 at 1:56 AM, Andrey Smirnov
<andrew.smirnov@gmail.com> wrote:
> The system has an external watchdog in the environment processor
> so the internal watchdog is of no use.
>
> Cc: Sascha Hauer <kernel@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: devicetree at vger.kernel.org
> Cc: linux-kernel at vger.kernel.org
> Cc: cphealy at gmail.com
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Patch looks good.
Just not clear if the authorship comes from you or Lucas.
If Lucas is the original author then his name should appear in the From field.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] ARM: dts: imx6: RDU2: disable internal watchdog
2017-12-27 11:09 ` [PATCH 1/2] ARM: dts: imx6: RDU2: disable internal watchdog Fabio Estevam
@ 2017-12-27 19:30 ` Andrey Smirnov
0 siblings, 0 replies; 6+ messages in thread
From: Andrey Smirnov @ 2017-12-27 19:30 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Dec 27, 2017 at 3:09 AM, Fabio Estevam <festevam@gmail.com> wrote:
> Hi Andrey,
>
> On Wed, Dec 27, 2017 at 1:56 AM, Andrey Smirnov
> <andrew.smirnov@gmail.com> wrote:
>> The system has an external watchdog in the environment processor
>> so the internal watchdog is of no use.
>>
>> Cc: Sascha Hauer <kernel@pengutronix.de>
>> Cc: Fabio Estevam <fabio.estevam@nxp.com>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Cc: Mark Rutland <mark.rutland@arm.com>
>> Cc: linux-arm-kernel at lists.infradead.org
>> Cc: devicetree at vger.kernel.org
>> Cc: linux-kernel at vger.kernel.org
>> Cc: cphealy at gmail.com
>> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
>> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
>
> Patch looks good.
>
> Just not clear if the authorship comes from you or Lucas.
>
> If Lucas is the original author then his name should appear in the From field.
Lucas is the original author and I am just a messenger. Sorry for the
confusion, will send a v2 with "From" fixed.
Sorry for the noise.
Thanks,
Andrey Smirnov
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-12-27 19:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-27 3:56 [PATCH 1/2] ARM: dts: imx6: RDU2: disable internal watchdog Andrey Smirnov
2017-12-27 3:56 ` [PATCH 2/2] ARM: dts: imx6: RDU2: correct RTC compatible Andrey Smirnov
2017-12-27 11:11 ` Fabio Estevam
2017-12-27 19:33 ` Andrey Smirnov
2017-12-27 11:09 ` [PATCH 1/2] ARM: dts: imx6: RDU2: disable internal watchdog Fabio Estevam
2017-12-27 19:30 ` Andrey Smirnov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox