public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: lkp@intel.com (kbuild test robot)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] nvmem: lpc18xx_otp: fix ptr_ret.cocci warnings
Date: Sun, 4 Mar 2018 21:04:28 +0800	[thread overview]
Message-ID: <20180304130428.GA11571@lkp-hsx02> (raw)
In-Reply-To: <20180228144106.16363-14-andrew.smirnov@gmail.com>

From: Fengguang Wu <fengguang.wu@intel.com>

drivers/nvmem/lpc18xx_otp.c:90:1-3: WARNING: PTR_ERR_OR_ZERO can be used


 Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

Fixes: e738282235ec ("nvmem: lpc18xx_otp: Convert to use devm_nvmem_register()")
CC: Andrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 lpc18xx_otp.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

--- a/drivers/nvmem/lpc18xx_otp.c
+++ b/drivers/nvmem/lpc18xx_otp.c
@@ -87,10 +87,7 @@ static int lpc18xx_otp_probe(struct plat
 	lpc18xx_otp_nvmem_config.priv = otp;
 
 	nvmem = devm_nvmem_register(&pdev->dev, &lpc18xx_otp_nvmem_config);
-	if (IS_ERR(nvmem))
-		return PTR_ERR(nvmem);
-
-	return 0;
+	return PTR_ERR_OR_ZERO(nvmem);
 }
 
 static const struct of_device_id lpc18xx_otp_dt_ids[] = {

  parent reply	other threads:[~2018-03-04 13:04 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-28 14:40 [PATCH v4 00/22] Verbatim device names and devm_nvmem_(un)register() Andrey Smirnov
2018-02-28 14:40 ` [PATCH v4 01/22] nvmem: Document struct nvmem_config Andrey Smirnov
2018-02-28 14:40 ` [PATCH v4 02/22] nvmem: core: Allow specifying device name verbatim Andrey Smirnov
2018-02-28 14:40 ` [PATCH v4 03/22] nvmem: Introduce devm_nvmem_(un)register() Andrey Smirnov
2018-02-28 14:40 ` [PATCH v4 04/22] nvmem: vf610-ocotp: Convert to use devm_nvmem_register() Andrey Smirnov
2018-02-28 14:40 ` [PATCH v4 05/22] nvmem: imx-ocotp: " Andrey Smirnov
2018-02-28 14:40 ` [PATCH v4 06/22] nvmem: uniphier-efuse: " Andrey Smirnov
2018-03-04  0:46   ` [PATCH] nvmem: uniphier-efuse: fix ptr_ret.cocci warnings kbuild test robot
2018-03-04  0:46   ` [PATCH v4 06/22] nvmem: uniphier-efuse: Convert to use devm_nvmem_register() kbuild test robot
2018-02-28 14:40 ` [PATCH v4 07/22] nvmem: snvs_lgpr: " Andrey Smirnov
2018-02-28 14:40 ` [PATCH v4 08/22] nvmem: qfprom: " Andrey Smirnov
2018-02-28 14:40 ` [PATCH v4 09/22] nvmem: rockchip-efuse: " Andrey Smirnov
2018-02-28 14:40 ` [PATCH v4 10/22] nvmem: mtk-efuse: " Andrey Smirnov
2018-02-28 14:40 ` [PATCH v4 11/22] nvmem: meson-mx-efuse: " Andrey Smirnov
2018-03-04 11:13   ` kbuild test robot
2018-03-04 11:13   ` [PATCH] nvmem: meson-mx-efuse: fix ptr_ret.cocci warnings kbuild test robot
2018-02-28 14:40 ` [PATCH v4 12/22] nvmem: meson-efuse: Convert to use devm_nvmem_register() Andrey Smirnov
2018-02-28 14:40 ` [PATCH v4 13/22] nvmem: lpc18xx_otp: " Andrey Smirnov
2018-03-04 13:04   ` kbuild test robot
2018-03-04 13:04   ` kbuild test robot [this message]
2018-02-28 14:40 ` [PATCH v4 14/22] nvmem: imx-iim: " Andrey Smirnov
2018-02-28 14:40 ` [PATCH v4 15/22] nvmem: bcm-ocotp: " Andrey Smirnov
2018-02-28 14:41 ` [PATCH v4 16/22] nvmem: meson-efuse: Do no gate COMPILE_TEST with MESON_SM Andrey Smirnov
2018-03-04  3:47   ` kbuild test robot
2018-03-04 17:56   ` kbuild test robot
2018-03-04 17:56   ` [PATCH] nvmem: meson-efuse: fix ptr_ret.cocci warnings kbuild test robot
2018-03-04 18:00     ` [kbuild-all] " Fabio Estevam
2018-02-28 14:41 ` [PATCH v4 17/22] nvmem: snvs_lpgpr: Convert commas to semicolons Andrey Smirnov
2018-02-28 14:41 ` [PATCH v4 18/22] nvmem: rockchip-efuse: Make use of of_device_get_match_data() Andrey Smirnov
2018-02-28 14:41 ` [PATCH v4 19/22] nvmem: vf610-ocotp: Do not use "&pdev->dev" explicitly Andrey Smirnov
2018-02-28 14:41 ` [PATCH v4 20/22] nvmem: rockchip-efuse: " Andrey Smirnov
2018-02-28 14:41 ` [PATCH v4 21/22] nvmem: imx-iim: " Andrey Smirnov
2018-02-28 14:41 ` [PATCH v4 22/22] nvmem: bcm-ocotp: " Andrey Smirnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180304130428.GA11571@lkp-hsx02 \
    --to=lkp@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox