Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: sun8i: h3: Re-enable EMAC on Orange Pi One
@ 2018-04-17  4:17 Chen-Yu Tsai
  2018-04-17  9:18 ` Maxime Ripard
  0 siblings, 1 reply; 2+ messages in thread
From: Chen-Yu Tsai @ 2018-04-17  4:17 UTC (permalink / raw)
  To: linux-arm-kernel

In commit f0842bc5637c ("ARM: dts: sun8i: h3: Enable HDMI output on H3
boards"), the hunk that enabled HDMI for the Orange Pi One did not add a

    status = "okay";

line for the HDMI node, inadvertenly using the one for the EMAC. This
resulted in the EMAC now being disabled. Whether this was due to a
rebase error or some other mishap is unknown.

This patch re-enables the EMAC by adding the status line to its node.

Fixes: f0842bc5637c ("ARM: dts: sun8i: h3: Enable HDMI output on H3 boards")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---

First fix for 4.17.

---
 arch/arm/boot/dts/sun8i-h3-orangepi-one.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts
index 3328fe583c9b..232f124ce62c 100644
--- a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts
+++ b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts
@@ -117,6 +117,7 @@
 	phy-handle = <&int_mii_phy>;
 	phy-mode = "mii";
 	allwinner,leds-active-low;
+	status = "okay";
 };
 
 &hdmi {
-- 
2.17.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] ARM: dts: sun8i: h3: Re-enable EMAC on Orange Pi One
  2018-04-17  4:17 [PATCH] ARM: dts: sun8i: h3: Re-enable EMAC on Orange Pi One Chen-Yu Tsai
@ 2018-04-17  9:18 ` Maxime Ripard
  0 siblings, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2018-04-17  9:18 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Apr 17, 2018 at 12:17:14PM +0800, Chen-Yu Tsai wrote:
> In commit f0842bc5637c ("ARM: dts: sun8i: h3: Enable HDMI output on H3
> boards"), the hunk that enabled HDMI for the Orange Pi One did not add a
> 
>     status = "okay";
> 
> line for the HDMI node, inadvertenly using the one for the EMAC. This
> resulted in the EMAC now being disabled. Whether this was due to a
> rebase error or some other mishap is unknown.
> 
> This patch re-enables the EMAC by adding the status line to its node.
> 
> Fixes: f0842bc5637c ("ARM: dts: sun8i: h3: Enable HDMI output on H3 boards")
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>

Applied, thanks!
Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180417/5cc91314/attachment.sig>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-04-17  9:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-17  4:17 [PATCH] ARM: dts: sun8i: h3: Re-enable EMAC on Orange Pi One Chen-Yu Tsai
2018-04-17  9:18 ` Maxime Ripard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox