* i2c-gpio and boards conversions to GPIO descriptors [not found] <20180525154144.GC19100@kw.sim.vm.gnt> @ 2018-05-25 17:30 ` Simon Guinot 2018-05-26 16:38 ` Linus Walleij 1 sibling, 0 replies; 2+ messages in thread From: Simon Guinot @ 2018-05-25 17:30 UTC (permalink / raw) To: linux-arm-kernel On Fri, May 25, 2018 at 05:41:44PM +0200, Simon Guinot wrote: > Hi Linus, Forwarding to some mailing lists I missed in a first place. > > I think your patch b2e63555592f "i2c: gpio: Convert to use descriptors" > may have broken i2c-gpio support for some boards using old fashion > platform_device declarations. > > Indeed when an "i2c-gpio" platform_device is registered with a fixed id > e.g. 0, then I think the device name becomes "i2c-gpio.0". And then this > won't match a lookup table registered with an "i2c-gpio" dev_id. > > Please double check this :) > > Simon -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180525/4bcae35d/attachment.sig> ^ permalink raw reply [flat|nested] 2+ messages in thread
* i2c-gpio and boards conversions to GPIO descriptors [not found] <20180525154144.GC19100@kw.sim.vm.gnt> 2018-05-25 17:30 ` i2c-gpio and boards conversions to GPIO descriptors Simon Guinot @ 2018-05-26 16:38 ` Linus Walleij 1 sibling, 0 replies; 2+ messages in thread From: Linus Walleij @ 2018-05-26 16:38 UTC (permalink / raw) To: linux-arm-kernel On Fri, May 25, 2018 at 5:41 PM, Simon Guinot <simon.guinot@sequanux.org> wrote: > Hi Linus, > > I think your patch b2e63555592f "i2c: gpio: Convert to use descriptors" > may have broken i2c-gpio support for some boards using old fashion > platform_device declarations. > > Indeed when an "i2c-gpio" platform_device is registered with a fixed id > e.g. 0, then I think the device name becomes "i2c-gpio.0". And then this > won't match a lookup table registered with an "i2c-gpio" dev_id. Yeah what a mess, I'm sending patches to fix it up, the ARM patch already sent, I will send a separate one for the MIPS machines. Sorry for the mess! :( Yours, Linus Walleij ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-26 16:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20180525154144.GC19100@kw.sim.vm.gnt>
2018-05-25 17:30 ` i2c-gpio and boards conversions to GPIO descriptors Simon Guinot
2018-05-26 16:38 ` Linus Walleij
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox