public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH 1/2] arm64: allwinner: a64: change TERES-I DLDO3's name to start with "vdd"
@ 2018-06-22 16:06 Icenowy Zheng
  2018-06-22 16:06 ` [PATCH 2/2] arm64: allwinner: a64: allow laptops to wake up from lid Icenowy Zheng
  0 siblings, 1 reply; 4+ messages in thread
From: Icenowy Zheng @ 2018-06-22 16:06 UTC (permalink / raw)
  To: linux-arm-kernel

Originally the name of the DLDO3 regulator on TERES-I is "eDP12", which
is not consistent with other regulator names.

Change it to "vdd-edp", in order to make it more consistent.

Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
---
 arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts
index d9baab3dc96b..02fecc42440c 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts
@@ -210,7 +210,7 @@
 &reg_dldo3 {
 	regulator-min-microvolt = <1200000>;
 	regulator-max-microvolt = <1200000>;
-	regulator-name = "eDP12";
+	regulator-name = "vdd-edp";
 };
 
 &reg_dldo4 {
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] arm64: allwinner: a64: allow laptops to wake up from lid
  2018-06-22 16:06 [PATCH 1/2] arm64: allwinner: a64: change TERES-I DLDO3's name to start with "vdd" Icenowy Zheng
@ 2018-06-22 16:06 ` Icenowy Zheng
  2018-06-25 17:09   ` Maxime Ripard
  0 siblings, 1 reply; 4+ messages in thread
From: Icenowy Zheng @ 2018-06-22 16:06 UTC (permalink / raw)
  To: linux-arm-kernel

Currently all ARM kernels will have s2idle enabled if CONFIG_SUSPEND is
present. In this case if the lid is closed, systemd-logind will enter
s2idle mode by default; however there's no possible wakeup source
defined, so the system will enter a forever idle.

Add the lid itself as a wakeup source, thus the system can wakeup when
the lid is opened.

Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
---
This patch is not related with the first patch, and have no dependency.

 arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts | 1 +
 arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts  | 1 +
 2 files changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts
index 58253d6f9be1..e6e5bf11b759 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts
@@ -49,6 +49,7 @@
 			linux,input-type = <EV_SW>;
 			linux,code = <SW_LID>;
 			linux,can-disable;
+			wakeup-source;
 		};
 	};
 
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts
index 02fecc42440c..33f78e745815 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts
@@ -38,6 +38,7 @@
 			gpios = <&r_pio 0 8 GPIO_ACTIVE_LOW>; /* PL8 */
 			linux,input-type = <EV_SW>;
 			linux,code = <SW_LID>;
+			wakeup-source;
 		};
 	};
 
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] arm64: allwinner: a64: allow laptops to wake up from lid
  2018-06-22 16:06 ` [PATCH 2/2] arm64: allwinner: a64: allow laptops to wake up from lid Icenowy Zheng
@ 2018-06-25 17:09   ` Maxime Ripard
  2018-06-26  3:17     ` Chen-Yu Tsai
  0 siblings, 1 reply; 4+ messages in thread
From: Maxime Ripard @ 2018-06-25 17:09 UTC (permalink / raw)
  To: linux-arm-kernel

On Sat, Jun 23, 2018 at 12:06:31AM +0800, Icenowy Zheng wrote:
> Currently all ARM kernels will have s2idle enabled if CONFIG_SUSPEND is
> present. In this case if the lid is closed, systemd-logind will enter
> s2idle mode by default; however there's no possible wakeup source
> defined, so the system will enter a forever idle.
> 
> Add the lid itself as a wakeup source, thus the system can wakeup when
> the lid is opened.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>

Applied both, thanks!
Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180625/312ba8b4/attachment-0001.sig>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 2/2] arm64: allwinner: a64: allow laptops to wake up from lid
  2018-06-25 17:09   ` Maxime Ripard
@ 2018-06-26  3:17     ` Chen-Yu Tsai
  0 siblings, 0 replies; 4+ messages in thread
From: Chen-Yu Tsai @ 2018-06-26  3:17 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Jun 26, 2018 at 1:09 AM, Maxime Ripard
<maxime.ripard@bootlin.com> wrote:
> On Sat, Jun 23, 2018 at 12:06:31AM +0800, Icenowy Zheng wrote:
>> Currently all ARM kernels will have s2idle enabled if CONFIG_SUSPEND is
>> present. In this case if the lid is closed, systemd-logind will enter
>> s2idle mode by default; however there's no possible wakeup source
>> defined, so the system will enter a forever idle.
>>
>> Add the lid itself as a wakeup source, thus the system can wakeup when
>> the lid is opened.
>>
>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>
> Applied both, thanks!
> Maxime

Icenowy, could you also look into having the power button as a wakeup source?
It has no device node, so you might have to look at how to implement it in
the driver.

ChenYu

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-06-26  3:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-22 16:06 [PATCH 1/2] arm64: allwinner: a64: change TERES-I DLDO3's name to start with "vdd" Icenowy Zheng
2018-06-22 16:06 ` [PATCH 2/2] arm64: allwinner: a64: allow laptops to wake up from lid Icenowy Zheng
2018-06-25 17:09   ` Maxime Ripard
2018-06-26  3:17     ` Chen-Yu Tsai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox