From: krzk@kernel.org (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/2] ARM: s3c24xx: Correct SD card write protect detection on Mini2440
Date: Mon, 10 Sep 2018 18:57:26 +0200 [thread overview]
Message-ID: <20180910165726.5vl24ng2dywexzsf@kozik-lap> (raw)
In-Reply-To: <ba9d81bf-f000-f6ae-30b1-3e922985f655@free.fr>
On Mon, Sep 10, 2018 at 06:55:09PM +0200, Cedric Roux wrote:
> On 09/10/2018 12:23 PM, Krzysztof Kozlowski wrote:
> >> static struct s3c24xx_mci_pdata mini2440_mmc_cfg __initdata = {
> >> - .gpio_detect = S3C2410_GPG(8),
> >> - .gpio_wprotect = S3C2410_GPH(8),
> >> - .set_power = NULL,
> >> - .ocr_avail = MMC_VDD_32_33|MMC_VDD_33_34,
> >> + .gpio_detect = S3C2410_GPG(8),
> >> + .gpio_wprotect = S3C2410_GPH(8),
> >> + .wprotect_invert = 1,
> >> + .set_power = NULL,
> >> + .ocr_avail = MMC_VDD_32_33|MMC_VDD_33_34,
> >
> > This looks unexpected... after patch 1 there should be only one change
> > - one new line added. What happened here?
>
> This is to align all the '='.
>
> These were spaces before the '=' so I also used spaces.
> Should I put TABs instead? I looked in the coding style
> and didn't find anything about this specific thing
> (maybe I read too fast though).
>
> And if this ends up unaligned because 'wprotect_invert'
> requires a second TAB for the others, should I do a separate
> commit?
Ah, I understand. It's okay, thanks!
Best regards,
Krzysztof
next prev parent reply other threads:[~2018-09-10 16:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 21:54 [PATCH v3 1/2] ARM: s3c24xx: formatting cleanup in mach-mini2440.c Cedric Roux
2018-09-07 21:54 ` [PATCH v3 2/2] ARM: s3c24xx: Correct SD card write protect detection on Mini2440 Cedric Roux
2018-09-10 10:23 ` Krzysztof Kozlowski
2018-09-10 16:55 ` Cedric Roux
2018-09-10 16:57 ` Krzysztof Kozlowski [this message]
2018-09-10 17:22 ` Krzysztof Kozlowski
2018-09-10 17:06 ` [PATCH v3 1/2] ARM: s3c24xx: formatting cleanup in mach-mini2440.c Krzysztof Kozlowski
2018-09-12 19:21 ` Joe Perches
2018-09-13 20:26 ` Cedric Roux
2018-09-17 8:33 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180910165726.5vl24ng2dywexzsf@kozik-lap \
--to=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox