From: joe@perches.com (Joe Perches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/2] ARM: s3c24xx: formatting cleanup in mach-mini2440.c
Date: Wed, 12 Sep 2018 12:21:37 -0700 [thread overview]
Message-ID: <b97d7ccc921572ca5d783584eea1de04341ab02f.camel@perches.com> (raw)
In-Reply-To: <20180907215446.15160-1-sed@free.fr>
On Fri, 2018-09-07 at 23:54 +0200, Cedric Roux wrote:
> Running:
> scripts/checkpatch.pl -f arch/arm/mach-s3c24xx/mach-mini2440.c
> revealed several errors and warnings.
>
> They were all removed, except one which is an #if 0 around the declaration
> of a gpio pin. This needs some more investigation and I prefer to let it
> here. This is not some dead code.
[]
> diff --git a/arch/arm/mach-s3c24xx/mach-mini2440.c b/arch/arm/mach-s3c24xx/mach-mini2440.c
[]
> @@ -674,17 +680,17 @@ static void __init mini2440_init(void)
> mini2440_fb_info.displays =
> &mini2440_lcd_cfg[features.lcd_index];
>
> - printk(KERN_INFO "MINI2440: LCD");
> + pr_info("MINI2440: LCD");
OK
> for (li = 0; li < ARRAY_SIZE(mini2440_lcd_cfg); li++)
> if (li == features.lcd_index)
> - printk(" [%d:%dx%d]", li,
> + pr_info(" [%d:%dx%d]", li,
> mini2440_lcd_cfg[li].width,
> mini2440_lcd_cfg[li].height);
pr_cont
> else
> - printk(" %d:%dx%d", li,
> + pr_info(" %d:%dx%d", li,
pr_cont
> mini2440_lcd_cfg[li].width,
> mini2440_lcd_cfg[li].height);
> - printk("\n");
> + pr_info("\n");
pr_cont
So only the first printk should use pr_info().
The subsequent printk uses should use pr_cont()
> s3c24xx_fb_set_platdata(&mini2440_fb_info);
> }
>
next prev parent reply other threads:[~2018-09-12 19:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 21:54 [PATCH v3 1/2] ARM: s3c24xx: formatting cleanup in mach-mini2440.c Cedric Roux
2018-09-07 21:54 ` [PATCH v3 2/2] ARM: s3c24xx: Correct SD card write protect detection on Mini2440 Cedric Roux
2018-09-10 10:23 ` Krzysztof Kozlowski
2018-09-10 16:55 ` Cedric Roux
2018-09-10 16:57 ` Krzysztof Kozlowski
2018-09-10 17:22 ` Krzysztof Kozlowski
2018-09-10 17:06 ` [PATCH v3 1/2] ARM: s3c24xx: formatting cleanup in mach-mini2440.c Krzysztof Kozlowski
2018-09-12 19:21 ` Joe Perches [this message]
2018-09-13 20:26 ` Cedric Roux
2018-09-17 8:33 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b97d7ccc921572ca5d783584eea1de04341ab02f.camel@perches.com \
--to=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox