* [PATCH v2 1/4] drm: sun4i: drop second PLL from A64 HDMI PHY
2018-09-16 4:34 [PATCH v2 0/4] Fix A64/R40 HDMI PHY device tree binding Icenowy Zheng
@ 2018-09-16 4:34 ` Icenowy Zheng
2018-09-16 4:34 ` [PATCH v2 2/4] dt-bindings: sun4i-drm: add compatible for R40 " Icenowy Zheng
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Icenowy Zheng @ 2018-09-16 4:34 UTC (permalink / raw)
To: linux-arm-kernel
The A64 HDMI PHY seems to be not able to use the second video PLL as
clock parent in experiments.
Drop the support for the second PLL from A64 HDMI PHY driver.
Fixes: b46e2c9f5f64 ("drm/sun4i: Add support for A64 HDMI PHY")
Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
---
Changes in v2:
- none.
drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c b/drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c
index 82502b351aec..a564b5dfe082 100644
--- a/drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c
+++ b/drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c
@@ -398,7 +398,6 @@ static struct regmap_config sun8i_hdmi_phy_regmap_config = {
static const struct sun8i_hdmi_phy_variant sun50i_a64_hdmi_phy = {
.has_phy_clk = true,
- .has_second_pll = true,
.phy_init = &sun8i_hdmi_phy_init_h3,
.phy_disable = &sun8i_hdmi_phy_disable_h3,
.phy_config = &sun8i_hdmi_phy_config_h3,
--
2.18.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v2 2/4] dt-bindings: sun4i-drm: add compatible for R40 HDMI PHY
2018-09-16 4:34 [PATCH v2 0/4] Fix A64/R40 HDMI PHY device tree binding Icenowy Zheng
2018-09-16 4:34 ` [PATCH v2 1/4] drm: sun4i: drop second PLL from A64 HDMI PHY Icenowy Zheng
@ 2018-09-16 4:34 ` Icenowy Zheng
2018-09-16 4:34 ` [PATCH v2 3/4] drm/sun4i: add support " Icenowy Zheng
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Icenowy Zheng @ 2018-09-16 4:34 UTC (permalink / raw)
To: linux-arm-kernel
The Allwinner R40 HDMI PHY is currently the only one that seems to be
able to select between two PLL inputs.
Add a compatible string for it, and the pll-1 clock input definition.
Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
---
Changes in v2:
- Rebased when removing original A64 binding patch.
.../devicetree/bindings/display/sunxi/sun4i-drm.txt | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
index f8773ecb7525..dcec1a6f8ee4 100644
--- a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
+++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
@@ -103,6 +103,7 @@ Required properties:
- compatible: value must be one of:
* allwinner,sun8i-a83t-hdmi-phy
* allwinner,sun8i-h3-hdmi-phy
+ * allwinner,sun8i-r40-hdmi-phy
* allwinner,sun50i-a64-hdmi-phy
- reg: base address and size of memory-mapped region
- clocks: phandles to the clocks feeding the HDMI PHY
@@ -112,9 +113,9 @@ Required properties:
- resets: phandle to the reset controller driving the PHY
- reset-names: must be "phy"
-H3 and A64 HDMI PHY require additional clocks:
+H3, A64 and R40 HDMI PHY require additional clocks:
- pll-0: parent of phy clock
- - pll-1: second possible phy clock parent (A64 only)
+ - pll-1: second possible phy clock parent (A64/R40 only)
TV Encoder
----------
--
2.18.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v2 3/4] drm/sun4i: add support for R40 HDMI PHY
2018-09-16 4:34 [PATCH v2 0/4] Fix A64/R40 HDMI PHY device tree binding Icenowy Zheng
2018-09-16 4:34 ` [PATCH v2 1/4] drm: sun4i: drop second PLL from A64 HDMI PHY Icenowy Zheng
2018-09-16 4:34 ` [PATCH v2 2/4] dt-bindings: sun4i-drm: add compatible for R40 " Icenowy Zheng
@ 2018-09-16 4:34 ` Icenowy Zheng
2018-09-16 4:34 ` [PATCH v2 4/4] ARM: sun8i: dts: drop A64 HDMI PHY fallback compatible from R40 DT Icenowy Zheng
2018-09-19 9:32 ` [PATCH v2 0/4] Fix A64/R40 HDMI PHY device tree binding Maxime Ripard
4 siblings, 0 replies; 6+ messages in thread
From: Icenowy Zheng @ 2018-09-16 4:34 UTC (permalink / raw)
To: linux-arm-kernel
The R40 SoC has a HDMI PHY that is possible to mux two video PLLs.
Add support for it.
Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
---
Changes in v2:
- none.
drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c b/drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c
index a564b5dfe082..471993097ced 100644
--- a/drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c
+++ b/drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c
@@ -416,6 +416,14 @@ static const struct sun8i_hdmi_phy_variant sun8i_h3_hdmi_phy = {
.phy_config = &sun8i_hdmi_phy_config_h3,
};
+static const struct sun8i_hdmi_phy_variant sun8i_r40_hdmi_phy = {
+ .has_phy_clk = true,
+ .has_second_pll = true,
+ .phy_init = &sun8i_hdmi_phy_init_h3,
+ .phy_disable = &sun8i_hdmi_phy_disable_h3,
+ .phy_config = &sun8i_hdmi_phy_config_h3,
+};
+
static const struct of_device_id sun8i_hdmi_phy_of_table[] = {
{
.compatible = "allwinner,sun50i-a64-hdmi-phy",
@@ -429,6 +437,10 @@ static const struct of_device_id sun8i_hdmi_phy_of_table[] = {
.compatible = "allwinner,sun8i-h3-hdmi-phy",
.data = &sun8i_h3_hdmi_phy,
},
+ {
+ .compatible = "allwinner,sun8i-r40-hdmi-phy",
+ .data = &sun8i_r40_hdmi_phy,
+ },
{ /* sentinel */ }
};
--
2.18.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v2 4/4] ARM: sun8i: dts: drop A64 HDMI PHY fallback compatible from R40 DT
2018-09-16 4:34 [PATCH v2 0/4] Fix A64/R40 HDMI PHY device tree binding Icenowy Zheng
` (2 preceding siblings ...)
2018-09-16 4:34 ` [PATCH v2 3/4] drm/sun4i: add support " Icenowy Zheng
@ 2018-09-16 4:34 ` Icenowy Zheng
2018-09-19 9:32 ` [PATCH v2 0/4] Fix A64/R40 HDMI PHY device tree binding Maxime Ripard
4 siblings, 0 replies; 6+ messages in thread
From: Icenowy Zheng @ 2018-09-16 4:34 UTC (permalink / raw)
To: linux-arm-kernel
The R40 HDMI PHY seems to be different to the A64 one, the A64 one
has no input mux, but the R40 one has.
Drop the A64 fallback compatible from the HDMI PHY node in R40 DT.
Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
---
Changes in v2:
- none.
arch/arm/boot/dts/sun8i-r40.dtsi | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/sun8i-r40.dtsi b/arch/arm/boot/dts/sun8i-r40.dtsi
index ffd9f00f74a4..5f547c161baf 100644
--- a/arch/arm/boot/dts/sun8i-r40.dtsi
+++ b/arch/arm/boot/dts/sun8i-r40.dtsi
@@ -800,8 +800,7 @@
};
hdmi_phy: hdmi-phy at 1ef0000 {
- compatible = "allwinner,sun8i-r40-hdmi-phy",
- "allwinner,sun50i-a64-hdmi-phy";
+ compatible = "allwinner,sun8i-r40-hdmi-phy";
reg = <0x01ef0000 0x10000>;
clocks = <&ccu CLK_BUS_HDMI1>, <&ccu CLK_HDMI_SLOW>,
<&ccu 7>, <&ccu 16>;
--
2.18.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v2 0/4] Fix A64/R40 HDMI PHY device tree binding
2018-09-16 4:34 [PATCH v2 0/4] Fix A64/R40 HDMI PHY device tree binding Icenowy Zheng
` (3 preceding siblings ...)
2018-09-16 4:34 ` [PATCH v2 4/4] ARM: sun8i: dts: drop A64 HDMI PHY fallback compatible from R40 DT Icenowy Zheng
@ 2018-09-19 9:32 ` Maxime Ripard
4 siblings, 0 replies; 6+ messages in thread
From: Maxime Ripard @ 2018-09-19 9:32 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Sep 16, 2018 at 12:34:05PM +0800, Icenowy Zheng wrote:
> When adding support for A64 HDMI PHY in 4.19, we assumed that the two
> PLL-VIDEOs can both feed the HDMI PHY clock. However experiments show
> that the mux bit discovered in R40 blob is not applicable on A64. This
> is not discovered, as normally with a single display pipeline only
> PLL-VIDEO0 will be used.
>
> In this patchset the second PLL is dropped, and a binding specially for
> R40 HDMI PHY is added (which seems to have the mux).
>
> PATCH 1 is dropping second PLL for A64 HDMI PHY, and PATCH 2 to 4
> are adding R40 HDMI PHY binding, as R40 behaves differently with A64
> with this.
>
> This patchset targets v4.19 fixes tree, because the binding is
> introduced in v4.19, and if we don't fix it there a wrong binding will
> be left in a stable version released. A64 display pipeline support is
> not yet in v4.19, but R40 support is in it.
Applied 1 and 4 as fixes for 4.19, 2 and 3 for 4.20, since they are
not fixes per se, and the R40 display engine is not enabled in 4.19
anyway.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180919/20ad0585/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread