From: Sudeep Holla <sudeep.holla@arm.com>
To: Quentin Perret <quentin.perret@arm.com>
Cc: nm@ti.com, linux-pm@vger.kernel.org, sboyd@kernel.org,
viresh.kumar@linaro.org, rjw@rjwysocki.net,
linux-kernel@vger.kernel.org, mka@chromium.org,
Sudeep Holla <sudeep.holla@arm.com>,
dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 4/5] cpufreq: arm_big_little: Register an Energy Model
Date: Fri, 1 Feb 2019 11:53:57 +0000 [thread overview]
Message-ID: <20190201115357.GB10042@e107155-lin> (raw)
In-Reply-To: <20190201093101.31869-5-quentin.perret@arm.com>
On Fri, Feb 01, 2019 at 09:31:00AM +0000, Quentin Perret wrote:
> From: Dietmar Eggemann <dietmar.eggemann@arm.com>
>
> Now that PM_OPP provides a helper function to estimate the power
> consumed by CPUs, make sure to try and register an Energy Model (EM)
> from the arm_big_little CPUFreq driver, hence ensuring interested
> subsystems (the task scheduler, for example) can make use of that
> information when available.
>
> Signed-off-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
> Signed-off-by: Quentin Perret <quentin.perret@arm.com>
> ---
> drivers/cpufreq/arm_big_little.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/cpufreq/arm_big_little.c b/drivers/cpufreq/arm_big_little.c
> index cf62a1f64dd7..18b05bcb2614 100644
> --- a/drivers/cpufreq/arm_big_little.c
> +++ b/drivers/cpufreq/arm_big_little.c
> @@ -487,6 +487,14 @@ static int bL_cpufreq_init(struct cpufreq_policy *policy)
> policy->cpuinfo.transition_latency =
> arm_bL_ops->get_transition_latency(cpu_dev);
>
> + ret = dev_pm_opp_get_opp_count(cpu_dev);
> + if (ret <= 0) {
> + dev_dbg(cpu_dev, "OPP table is not ready, deferring probe\n");
> + return -EPROBE_DEFER;
> + }
The only user of this has the check in init_opp_table that gets called from
get_cluster_clk_and_freq_table. So the above is not necessary, you can drop
it.
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-01 11:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 9:30 [PATCH v3 0/5] Register an Energy Model for Arm reference platforms Quentin Perret
2019-02-01 9:30 ` [PATCH v3 1/5] PM / OPP: Introduce a power estimation helper Quentin Perret
2019-02-01 12:04 ` Sudeep Holla
2019-02-01 12:09 ` Quentin Perret
2019-02-01 12:27 ` Sudeep Holla
2019-02-01 12:44 ` Sudeep Holla
2019-02-01 18:16 ` Matthias Kaehlcke
2019-02-01 9:30 ` [PATCH v3 2/5] cpufreq: dt: Register an Energy Model Quentin Perret
2019-02-01 9:30 ` [PATCH v3 3/5] cpufreq: scpi: " Quentin Perret
2019-02-01 9:31 ` [PATCH v3 4/5] cpufreq: arm_big_little: " Quentin Perret
2019-02-01 11:53 ` Sudeep Holla [this message]
2019-02-01 12:11 ` Quentin Perret
2019-02-01 9:31 ` [PATCH v3 5/5] cpufreq: scmi: " Quentin Perret
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190201115357.GB10042@e107155-lin \
--to=sudeep.holla@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mka@chromium.org \
--cc=nm@ti.com \
--cc=quentin.perret@arm.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox