From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Konstantin Sudakov <k.sudakov@integrasources.com>,
bbrezillon@kernel.org, dri-devel@lists.freedesktop.org,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
Chen-Yu Tsai <wens@csie.org>, Sean Paul <seanpaul@chromium.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Jagan Teki <jagan@openedev.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/4] drm/panel: Add Rondo RB070D30 panel
Date: Tue, 5 Feb 2019 16:31:38 +0100 [thread overview]
Message-ID: <20190205153138.ofvsxbajmm44natx@flea> (raw)
In-Reply-To: <20190129154833.GA22238@ravnborg.org>
[-- Attachment #1.1: Type: text/plain, Size: 951 bytes --]
Hi Sam,
On Tue, Jan 29, 2019 at 04:48:33PM +0100, Sam Ravnborg wrote:
> > > > + }
> > > > +
> > > > + drm_mode_set_name(mode);
> > > > +
> > > > + mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;
> > > > + drm_mode_probed_add(connector, mode);
> > > > +
> > > > + panel->connector->display_info.bpc = 8;
> > > > + panel->connector->display_info.width_mm = 154;
> > > > + panel->connector->display_info.height_mm = 85;
> > > See comment on height above.
> > > Same goes for bpc
> >
> > Sorry, I'm not sure to follow you here. bpc and height are both set?
>
> I assumed that if we had specified height and width in display_mode
> then we did not have to do it here. But I may be wrong.
It looks like it's not done by the core, but panel-simple simply
copies it, so I'll do it as well.
Thanks for the suggestion!
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-02-05 15:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 15:54 [PATCH 0/4] drm/sun4i: dsi: Add burst mode support Maxime Ripard
2019-01-23 15:54 ` [PATCH 1/4] drm/sun4i: dsi: Restrict DSI tcon clock divider Maxime Ripard
2019-01-28 12:08 ` Jagan Teki
2019-01-29 15:39 ` Paul Kocialkowski
2019-01-23 15:54 ` [PATCH 2/4] drm/sun4i: dsi: Change the start delay calculation Maxime Ripard
2019-01-29 15:40 ` Paul Kocialkowski
2019-01-30 3:23 ` Chen-Yu Tsai
2019-02-05 16:48 ` Chen-Yu Tsai
2019-02-06 14:12 ` Maxime Ripard
2019-02-06 14:32 ` Chen-Yu Tsai
2019-01-23 15:54 ` [PATCH 3/4] drm/sun4i: dsi: Add burst support Maxime Ripard
2019-02-05 18:28 ` Chen-Yu Tsai
2019-02-07 14:27 ` Maxime Ripard
2019-01-23 15:54 ` [PATCH 4/4] drm/panel: Add Rondo RB070D30 panel Maxime Ripard
2019-01-26 15:39 ` Sam Ravnborg
[not found] ` <1548566815.202603076@f339.i.mail.ru>
2019-01-27 7:33 ` Sam Ravnborg
2019-01-29 15:37 ` Maxime Ripard
2019-01-29 15:48 ` Sam Ravnborg
2019-02-05 15:31 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190205153138.ofvsxbajmm44natx@flea \
--to=maxime.ripard@bootlin.com \
--cc=bbrezillon@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jagan@openedev.com \
--cc=k.sudakov@integrasources.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=sam@ravnborg.org \
--cc=seanpaul@chromium.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox