From: Sudeep Holla <sudeep.holla@arm.com>
To: Wen Yang <wen.yang99@zte.com.cn>
Cc: wang.yi59@zte.com.cn,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Liviu Dudau <liviu.dudau@arm.com>,
linux-kernel@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 12/15] ARM: vexpress: fix a leaked reference by adding missing of_node_put
Date: Tue, 5 Mar 2019 11:39:30 +0000 [thread overview]
Message-ID: <20190305113930.GB2066@e107155-lin> (raw)
In-Reply-To: <1551785646-46173-12-git-send-email-wen.yang99@zte.com.cn>
On Tue, Mar 05, 2019 at 07:34:03PM +0800, Wen Yang wrote:
> The call to of_get_next_child returns a node pointer with refcount
> incremented thus it must be explicitly decremented after the last
> usage.
>
> Detected by coccinelle with the following warnings:
> ./arch/arm/mach-vexpress/dcscb.c:150:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 145, but without a corresponding object release within this function.
> ./arch/arm/mach-vexpress/dcscb.c:160:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 145, but without a corresponding object release within this function.
> ./arch/arm/mach-vexpress/dcscb.c:171:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 145, but without a corresponding object release within this function.
>
> Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Liviu Dudau <liviu.dudau@arm.com>
> Cc: Sudeep Holla <sudeep.holla@arm.com>
I already Acked assuming you have plans to take this as series. There's
no cover letter mentioning your plans to merge this or note to individual
platform maintainers. Please let us know.
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-05 11:39 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 11:33 [PATCH v2 01/15] ARM: actions: fix a leaked reference by adding missing of_node_put Wen Yang
2019-03-05 11:33 ` [PATCH v2 02/15] ARM: bcm: " Wen Yang
2019-03-05 17:24 ` Ray Jui
2019-03-08 18:50 ` Florian Fainelli
2019-03-05 11:33 ` [PATCH v2 03/15] ARM: exynos: " Wen Yang
2019-03-19 20:39 ` Krzysztof Kozlowski
2019-03-05 11:33 ` [PATCH v2 04/15] ARM: hisi: " Wen Yang
2019-04-05 11:26 ` Markus Elfring
2019-03-05 11:33 ` [PATCH v2 05/15] ARM: imx51: " Wen Yang
2019-03-06 2:58 ` Shawn Guo
2019-03-05 11:33 ` [PATCH v2 06/15] arm: npcm: " Wen Yang
2019-03-06 12:02 ` Avi Fishman
2019-03-05 11:33 ` [PATCH v2 07/15] ARM: rockchip: " Wen Yang
2019-04-23 17:48 ` Heiko Stuebner
2019-03-05 11:33 ` [PATCH v2 08/15] ARM: shmobile: " Wen Yang
2019-03-08 12:07 ` Simon Horman
2019-03-05 11:34 ` [PATCH v2 09/15] ARM: socfpga: " Wen Yang
2019-03-05 11:34 ` [PATCH v2 10/15] ARM: sunxi: " Wen Yang
2019-03-05 11:59 ` maxime.ripard
2019-03-05 11:34 ` [PATCH v2 11/15] ARM: versatile: " Wen Yang
2019-03-05 11:34 ` [PATCH v2 12/15] ARM: vexpress: " Wen Yang
2019-03-05 11:39 ` Sudeep Holla [this message]
2019-03-05 11:34 ` [PATCH v2 13/15] ARM: zynq: " Wen Yang
2019-03-05 11:34 ` [PATCH v2 14/15] arm64: cpu_ops: " Wen Yang
2019-04-01 15:37 ` Will Deacon
[not found] ` <201904031356099956278@zte.com.cn>
2019-04-03 12:44 ` 答复: Re: [PATCH v2 14/15] arm64: cpu_ops: fix a leaked reference byadding " Will Deacon
2019-03-05 11:34 ` [PATCH v2 15/15] ARM: axxia: fix a leaked reference by adding " Wen Yang
2019-03-05 11:40 ` [PATCH v2 01/15] ARM: actions: " Russell King - ARM Linux admin
2019-03-09 2:17 ` Manivannan Sadhasivam
2019-03-09 8:14 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190305113930.GB2066@e107155-lin \
--to=sudeep.holla@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=liviu.dudau@arm.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=wang.yi59@zte.com.cn \
--cc=wen.yang99@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox