Re: [PATCH v2] dmaengine: stm32-mdma: Revert "Add a check on read_u32_array"

From: Vinod Koul <vkoul@kernel.org>
To: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>,
	linux-kernel@vger.kernel.org,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	dmaengine@vger.kernel.org,
	Dan Williams <dan.j.williams@intel.com>,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] dmaengine: stm32-mdma: Revert "Add a check on read_u32_array"
Date: Mon, 25 Mar 2019 21:58:49 +0530	[thread overview]
Message-ID: <20190325162849.GS5348@vkoul-mobl> (raw)
In-Reply-To: <1553530915-1961-1-git-send-email-pierre-yves.mordret@st.com>

On 25-03-19, 17:21, Pierre-Yves MORDRET wrote:
> This reverts commit 906b40b246b0 ("Add a check on read_u32_array")

This and patch title should contain:
906b40b246b0 ("dmaengine: stm32-mdma: Add a check on read_u32_array")

I have fixed it up and applied.

Thanks

> As stated by bindings "st,ahb-addr-masks" is optional.
> The statement inserted by this commit makes this property
> mandatory and prevents MDMA to be probed in case property not present.
> 
> Signed-off-by: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>
> ---
>   Version history:
>     v2:
>        * review commit message
>     v1:
>        * Initial
> ---
> ---
>  drivers/dma/stm32-mdma.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/dma/stm32-mdma.c b/drivers/dma/stm32-mdma.c
> index 4e0eede..ac0301b 100644
> --- a/drivers/dma/stm32-mdma.c
> +++ b/drivers/dma/stm32-mdma.c
> @@ -1578,11 +1578,9 @@ static int stm32_mdma_probe(struct platform_device *pdev)
>  
>  	dmadev->nr_channels = nr_channels;
>  	dmadev->nr_requests = nr_requests;
> -	ret = device_property_read_u32_array(&pdev->dev, "st,ahb-addr-masks",
> +	device_property_read_u32_array(&pdev->dev, "st,ahb-addr-masks",
>  				       dmadev->ahb_addr_masks,
>  				       count);
> -	if (ret)
> -		return ret;
>  	dmadev->nr_ahb_addr_masks = count;
>  
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -- 
> 2.7.4

-- 
~Vinod

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel