From: Pierre Yves MORDRET <pierre-yves.mordret@st.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: Alexandre Torgue <alexandre.torgue@st.com>,
linux-kernel@vger.kernel.org,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
dmaengine@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] dmaengine: stm32-mdma: Revert "Add a check on read_u32_array"
Date: Tue, 26 Mar 2019 09:55:00 +0100 [thread overview]
Message-ID: <8a28e0d8-93d6-3cb7-a53a-26017aa89e16@st.com> (raw)
In-Reply-To: <20190325162849.GS5348@vkoul-mobl>
On 3/25/19 5:28 PM, Vinod Koul wrote:
> On 25-03-19, 17:21, Pierre-Yves MORDRET wrote:
>> This reverts commit 906b40b246b0 ("Add a check on read_u32_array")
>
> This and patch title should contain:
> 906b40b246b0 ("dmaengine: stm32-mdma: Add a check on read_u32_array")
>
> I have fixed it up and applied.
Darn it, sorry.
Many thanks btw :)
>
> Thanks
>
>> As stated by bindings "st,ahb-addr-masks" is optional.
>> The statement inserted by this commit makes this property
>> mandatory and prevents MDMA to be probed in case property not present.
>>
>> Signed-off-by: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>
>> ---
>> Version history:
>> v2:
>> * review commit message
>> v1:
>> * Initial
>> ---
>> ---
>> drivers/dma/stm32-mdma.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/dma/stm32-mdma.c b/drivers/dma/stm32-mdma.c
>> index 4e0eede..ac0301b 100644
>> --- a/drivers/dma/stm32-mdma.c
>> +++ b/drivers/dma/stm32-mdma.c
>> @@ -1578,11 +1578,9 @@ static int stm32_mdma_probe(struct platform_device *pdev)
>>
>> dmadev->nr_channels = nr_channels;
>> dmadev->nr_requests = nr_requests;
>> - ret = device_property_read_u32_array(&pdev->dev, "st,ahb-addr-masks",
>> + device_property_read_u32_array(&pdev->dev, "st,ahb-addr-masks",
>> dmadev->ahb_addr_masks,
>> count);
>> - if (ret)
>> - return ret;
>> dmadev->nr_ahb_addr_masks = count;
>>
>> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> --
>> 2.7.4
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-03-26 8:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 16:21 [PATCH v2] dmaengine: stm32-mdma: Revert "Add a check on read_u32_array" Pierre-Yves MORDRET
2019-03-25 16:28 ` Vinod Koul
2019-03-26 8:55 ` Pierre Yves MORDRET [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a28e0d8-93d6-3cb7-a53a-26017aa89e16@st.com \
--to=pierre-yves.mordret@st.com \
--cc=alexandre.torgue@st.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox