* [PATCH v3 0/1] ARM: dts: sun8i: a83t: Add missing cooling device properties for CPUs @ 2019-04-01 13:36 megous 2019-04-01 13:36 ` [PATCH v3 1/1] ARM: dts: sun8i: a83t: Add missing CPU clock references megous 0 siblings, 1 reply; 3+ messages in thread From: megous @ 2019-04-01 13:36 UTC (permalink / raw) To: Maxime Ripard, Chen-Yu Tsai Cc: Ondrej Jirman, Mark Rutland, devicetree, linux-kernel, linux-sunxi, Rob Herring, linux-arm-kernel From: Ondrej Jirman <megous@megous.com> (Part of the series was already applied, so this only contains the remaining patch.) This series adds some properties to prepare for passive cooling via CPU frequency down-regulation, and fixes cpufreq for various CPU hotplug situations. #cooling-cells patch is not strictly necessary now, but now that SID changes are soon to be merged, thermal sensor patches are likely to follow, and it will be useful in short order, I expect. Please take a look. regards, Ondrej Jirman Changes for v2: - split the former single patch into a series - reformulated descriptions to accommodate the split Changes for v3: - removed already applied patch - re-ordered clock properties - removed clock-names (not needed and not documented) Ondrej Jirman (1): ARM: dts: sun8i: a83t: Add missing CPU clock references arch/arm/boot/dts/sun8i-a83t.dtsi | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) -- 2.21.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v3 1/1] ARM: dts: sun8i: a83t: Add missing CPU clock references 2019-04-01 13:36 [PATCH v3 0/1] ARM: dts: sun8i: a83t: Add missing cooling device properties for CPUs megous @ 2019-04-01 13:36 ` megous 2019-04-01 14:31 ` Maxime Ripard 0 siblings, 1 reply; 3+ messages in thread From: megous @ 2019-04-01 13:36 UTC (permalink / raw) To: Maxime Ripard, Chen-Yu Tsai Cc: Ondrej Jirman, Mark Rutland, devicetree, linux-kernel, linux-sunxi, Rob Herring, linux-arm-kernel From: Ondrej Jirman <megous@megous.com> A83T DTSI has cpu clocks defined only on the first CPU in each cluster. We can bring down any CPU in the cluster, so we need to define clock for each CPU, so that the system knows what clock to use if the first CPU is down. Also move the clocks property below the compatible on cpus where it is already defined. Property "clock-names" is not needed. Signed-off-by: Ondrej Jirman <megous@megous.com> --- arch/arm/boot/dts/sun8i-a83t.dtsi | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi index 7a40b7d77ec0..b241058dc6b0 100644 --- a/arch/arm/boot/dts/sun8i-a83t.dtsi +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi @@ -61,10 +61,9 @@ #size-cells = <0>; cpu0: cpu@0 { - clocks = <&ccu CLK_C0CPUX>; - clock-names = "cpu"; compatible = "arm,cortex-a7"; device_type = "cpu"; + clocks = <&ccu CLK_C0CPUX>; operating-points-v2 = <&cpu0_opp_table>; cci-control-port = <&cci_control0>; enable-method = "allwinner,sun8i-a83t-smp"; @@ -75,6 +74,7 @@ cpu@1 { compatible = "arm,cortex-a7"; device_type = "cpu"; + clocks = <&ccu CLK_C0CPUX>; operating-points-v2 = <&cpu0_opp_table>; cci-control-port = <&cci_control0>; enable-method = "allwinner,sun8i-a83t-smp"; @@ -85,6 +85,7 @@ cpu@2 { compatible = "arm,cortex-a7"; device_type = "cpu"; + clocks = <&ccu CLK_C0CPUX>; operating-points-v2 = <&cpu0_opp_table>; cci-control-port = <&cci_control0>; enable-method = "allwinner,sun8i-a83t-smp"; @@ -95,6 +96,7 @@ cpu@3 { compatible = "arm,cortex-a7"; device_type = "cpu"; + clocks = <&ccu CLK_C0CPUX>; operating-points-v2 = <&cpu0_opp_table>; cci-control-port = <&cci_control0>; enable-method = "allwinner,sun8i-a83t-smp"; @@ -103,10 +105,9 @@ }; cpu100: cpu@100 { - clocks = <&ccu CLK_C1CPUX>; - clock-names = "cpu"; compatible = "arm,cortex-a7"; device_type = "cpu"; + clocks = <&ccu CLK_C1CPUX>; operating-points-v2 = <&cpu1_opp_table>; cci-control-port = <&cci_control1>; enable-method = "allwinner,sun8i-a83t-smp"; @@ -117,6 +118,7 @@ cpu@101 { compatible = "arm,cortex-a7"; device_type = "cpu"; + clocks = <&ccu CLK_C1CPUX>; operating-points-v2 = <&cpu1_opp_table>; cci-control-port = <&cci_control1>; enable-method = "allwinner,sun8i-a83t-smp"; @@ -127,6 +129,7 @@ cpu@102 { compatible = "arm,cortex-a7"; device_type = "cpu"; + clocks = <&ccu CLK_C1CPUX>; operating-points-v2 = <&cpu1_opp_table>; cci-control-port = <&cci_control1>; enable-method = "allwinner,sun8i-a83t-smp"; @@ -137,6 +140,7 @@ cpu@103 { compatible = "arm,cortex-a7"; device_type = "cpu"; + clocks = <&ccu CLK_C1CPUX>; operating-points-v2 = <&cpu1_opp_table>; cci-control-port = <&cci_control1>; enable-method = "allwinner,sun8i-a83t-smp"; -- 2.21.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3 1/1] ARM: dts: sun8i: a83t: Add missing CPU clock references 2019-04-01 13:36 ` [PATCH v3 1/1] ARM: dts: sun8i: a83t: Add missing CPU clock references megous @ 2019-04-01 14:31 ` Maxime Ripard 0 siblings, 0 replies; 3+ messages in thread From: Maxime Ripard @ 2019-04-01 14:31 UTC (permalink / raw) To: megous Cc: Mark Rutland, devicetree, linux-sunxi, linux-kernel, Chen-Yu Tsai, Rob Herring, linux-arm-kernel [-- Attachment #1.1: Type: text/plain, Size: 638 bytes --] On Mon, Apr 01, 2019 at 03:36:10PM +0200, megous@megous.com wrote: > From: Ondrej Jirman <megous@megous.com> > > A83T DTSI has cpu clocks defined only on the first CPU in each cluster. > We can bring down any CPU in the cluster, so we need to define clock > for each CPU, so that the system knows what clock to use if the first > CPU is down. > > Also move the clocks property below the compatible on cpus where it is > already defined. Property "clock-names" is not needed. > > Signed-off-by: Ondrej Jirman <megous@megous.com> Applied, thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-01 14:32 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-04-01 13:36 [PATCH v3 0/1] ARM: dts: sun8i: a83t: Add missing cooling device properties for CPUs megous 2019-04-01 13:36 ` [PATCH v3 1/1] ARM: dts: sun8i: a83t: Add missing CPU clock references megous 2019-04-01 14:31 ` Maxime Ripard
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox