From: Leo Yan <leo.yan@linaro.org>
To: Valentin Schneider <valentin.schneider@arm.com>
Cc: marc.w.gonzalez@free.fr, linux-kernel@vger.kernel.org,
john.stultz@linaro.org, liwei213@huawei.com, olof@lixom.net,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: defconfig: Update UFSHCD for Hi3660 soc
Date: Wed, 17 Apr 2019 08:25:46 +0800 [thread overview]
Message-ID: <20190417002546.GC6202@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <20190416170221.13764-1-valentin.schneider@arm.com>
On Tue, Apr 16, 2019 at 06:02:21PM +0100, Valentin Schneider wrote:
> Commit 7ee7ef24d02d ("scsi: arm64: defconfig: enable configs for Hisilicon ufs")
> set 'CONFIG_SCSI_UFS_HISI=y', but the configs it depends
> on
>
> (CONFIG_SCSI_HFSHCD_PLATFORM && CONFIG_SCSI_UFSHCD)
>
> were left to being built as modules.
>
> Commit 1f4fa50dd48f ("arm64: defconfig: Regenerate for v4.20") "fixed"
> that by reverting to 'CONFIG_SCSI_UFS_HISI=m'.
>
> Thing is, if the rootfs is stored in the on-board flash (which
> is the "canonical" way of doing things), we either need these drivers
> to be built-in, or we need to fiddle with an initramfs to access that
> flash and eventually load the modules installed over there.
>
> The former is the easiest, do that.
>
> Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
Looks good to me:
Reviewed-by: Leo Yan <leo.yan@linaro.org>
> ---
> arch/arm64/configs/defconfig | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 2d9c39033c1a..32fb03503b0b 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -222,10 +222,10 @@ CONFIG_BLK_DEV_SD=y
> CONFIG_SCSI_SAS_ATA=y
> CONFIG_SCSI_HISI_SAS=y
> CONFIG_SCSI_HISI_SAS_PCI=y
> -CONFIG_SCSI_UFSHCD=m
> -CONFIG_SCSI_UFSHCD_PLATFORM=m
> +CONFIG_SCSI_UFSHCD=y
> +CONFIG_SCSI_UFSHCD_PLATFORM=y
> CONFIG_SCSI_UFS_QCOM=m
> -CONFIG_SCSI_UFS_HISI=m
> +CONFIG_SCSI_UFS_HISI=y
> CONFIG_ATA=y
> CONFIG_SATA_AHCI=y
> CONFIG_SATA_AHCI_PLATFORM=y
> --
> 2.20.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-17 0:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 17:02 [PATCH] arm64: defconfig: Update UFSHCD for Hi3660 soc Valentin Schneider
2019-04-17 0:25 ` Leo Yan [this message]
2019-04-17 8:03 ` Marc Gonzalez
2019-04-17 10:09 ` Valentin Schneider
2019-04-29 6:19 ` Olof Johansson
2019-04-29 6:19 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190417002546.GC6202@leoy-ThinkPad-X240s \
--to=leo.yan@linaro.org \
--cc=john.stultz@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liwei213@huawei.com \
--cc=marc.w.gonzalez@free.fr \
--cc=olof@lixom.net \
--cc=valentin.schneider@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox