From: Olof Johansson <olof@lixom.net>
To: Marc Gonzalez <marc.w.gonzalez@free.fr>
Cc: arm-soc <arm@kernel.org>,
Valentin Schneider <valentin.schneider@arm.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: defconfig: Update UFSHCD for Hi3660 soc
Date: Sun, 28 Apr 2019 23:19:29 -0700 [thread overview]
Message-ID: <20190429061929.zv6d2pdu5fobpzhy@localhost> (raw)
In-Reply-To: <d12c9e59-06f1-d836-6797-ae87a708df9d@free.fr>
On Wed, Apr 17, 2019 at 10:03:26AM +0200, Marc Gonzalez wrote:
> On 16/04/2019 19:02, Valentin Schneider wrote:
>
> > Commit 7ee7ef24d02d ("scsi: arm64: defconfig: enable configs for Hisilicon ufs")
> > set 'CONFIG_SCSI_UFS_HISI=y', but the configs it depends on
> >
> > (CONFIG_SCSI_HFSHCD_PLATFORM && CONFIG_SCSI_UFSHCD)
> >
> > were left to being built as modules.
> >
> > Commit 1f4fa50dd48f ("arm64: defconfig: Regenerate for v4.20") "fixed"
> > that by reverting to 'CONFIG_SCSI_UFS_HISI=m'.
> >
> > Thing is, if the rootfs is stored in the on-board flash (which
> > is the "canonical" way of doing things), we either need these drivers
> > to be built-in, or we need to fiddle with an initramfs to access that
> > flash and eventually load the modules installed over there.
> >
> > The former is the easiest, do that.
>
> By that logic, wouldn't every UFS driver need to be built-in?
>
> SCSI_UFS_QCOM
> SCSI_UFS_MEDIATEK
> SCSI_UFS_HISI
>
> And generalizing, wouldn't every storage driver also need to be built-in?
> (SDHC, MMC, USB, MTD, etc)
The general guidance is that storage drivers that known well-supported
platforms need to mount root filesystem from are fine as built-in, but
secondary storage should still be modules.
> (FWIW, I dislike Christmas-tree defconfigs.)
I don't know what you mean with this, but the above is just fine. You should
feel free to use something else than just the defconfig for your system if you
feel it is getting too large for your personal use case.
-Olof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-29 7:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 17:02 [PATCH] arm64: defconfig: Update UFSHCD for Hi3660 soc Valentin Schneider
2019-04-17 0:25 ` Leo Yan
2019-04-17 8:03 ` Marc Gonzalez
2019-04-17 10:09 ` Valentin Schneider
2019-04-29 6:19 ` Olof Johansson [this message]
2019-04-29 6:19 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190429061929.zv6d2pdu5fobpzhy@localhost \
--to=olof@lixom.net \
--cc=arm@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marc.w.gonzalez@free.fr \
--cc=valentin.schneider@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox