From: Vinod Koul <vkoul@kernel.org>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: dmaengine@vger.kernel.org, dan.j.williams@intel.com,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] dmaengine: ti: edma: Enable support for polled (memcpy) completion
Date: Tue, 21 May 2019 12:51:31 +0530 [thread overview]
Message-ID: <20190521072131.GB15118@vkoul-mobl> (raw)
In-Reply-To: <ce1a2e96-bc4b-3998-0c36-362867907177@ti.com>
On 21-05-19, 09:16, Peter Ujfalusi wrote:
> On 21/05/2019 8.04, Vinod Koul wrote:
> > On 14-05-19, 11:09, Peter Ujfalusi wrote:
> >> return vchan_tx_prep(&echan->vchan, &edesc->vdesc, tx_flags);
> >> @@ -1801,6 +1804,20 @@ static enum dma_status edma_tx_status(struct dma_chan *chan,
> >> unsigned long flags;
> >>
> >> ret = dma_cookie_status(chan, cookie, txstate);
> >> +
> >> + if (ret != DMA_COMPLETE && echan->edesc && !echan->edesc->cyclic) {
> >> + struct edma_cc *ecc = echan->ecc;
> >> + int channel = EDMA_CHAN_SLOT(echan->ch_num);
> >> + int j = (channel >> 5);
> >> + unsigned int mask = BIT(channel & 0x1f);
> >
> > GENMASK or define a macro instead of a magic number?
>
> So it is better to change the other places first from where I have just
> copied this.
That would be nice as well :)
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-05-21 7:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 8:09 [PATCH] dmaengine: ti: edma: Enable support for polled (memcpy) completion Peter Ujfalusi
2019-05-21 5:04 ` Vinod Koul
2019-05-21 6:16 ` Peter Ujfalusi
2019-05-21 7:21 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521072131.GB15118@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox