[PATCH] clk-sunxi: fix a missing-check bug in sunxi_divs_clk_setup()

* [PATCH] clk-sunxi: fix a missing-check bug in sunxi_divs_clk_setup()
@ 2019-05-28  2:18 Gen Zhang
  2019-05-29  8:05 ` Maxime Ripard
  0 siblings, 1 reply; 2+ messages in thread
From: Gen Zhang @ 2019-05-28  2:18 UTC (permalink / raw)
  To: emilio, mturquette, sboyd, maxime.ripard, wens
  Cc: linux-clk, linux-arm-kernel, linux-kernel

In sunxi_divs_clk_setup(), 'derived_name' is allocated by kstrndup().
It returns NULL when fails. 'derived_name' should be checked.

Signed-off-by: Gen Zhang <blackgod016574@gmail.com>
---

diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
index f5b1c00..830bfb7 100644
--- a/drivers/clk/sunxi/clk-sunxi.c
+++ b/drivers/clk/sunxi/clk-sunxi.c
@@ -989,6 +989,8 @@ static struct clk ** __init sunxi_divs_clk_setup(struct device_node *node,
 		if (endp) {
 			derived_name = kstrndup(clk_name, endp - clk_name,
 						GFP_KERNEL);
+			if (!derived_name)
+				return NULL;
 			factors.name = derived_name;
 		} else {
 			factors.name = clk_name;
---

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 2+ messages in thread