From: Maxime Ripard <maxime.ripard@bootlin.com>
To: "Clément Péron" <peron.clem@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-sunxi@googlegroups.com,
linux-kernel@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
Rob Herring <robh+dt@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v4 04/13] media: rc: sunxi: Add RXSTA bits definition
Date: Wed, 5 Jun 2019 11:51:41 +0200 [thread overview]
Message-ID: <20190605095141.psrq6mhk63zto77s@flea> (raw)
In-Reply-To: <20190604162959.29199-5-peron.clem@gmail.com>
On Tue, Jun 04, 2019 at 06:29:50PM +0200, Clément Péron wrote:
> We are using RXINT bits definition when looking at RXSTA register.
>
> These bits are equal but it's not really proper.
>
> Introduce the RXSTA bits and use them to have coherency.
>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>
> ---
> drivers/media/rc/sunxi-cir.c | 18 ++++++++++++------
> 1 file changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/media/rc/sunxi-cir.c b/drivers/media/rc/sunxi-cir.c
> index 0504ebfc831f..572bd2257d35 100644
> --- a/drivers/media/rc/sunxi-cir.c
> +++ b/drivers/media/rc/sunxi-cir.c
> @@ -48,11 +48,11 @@
>
> /* Rx Interrupt Enable */
> #define SUNXI_IR_RXINT_REG 0x2C
> -/* Rx FIFO Overflow */
> +/* Rx FIFO Overflow Interrupt Enable */
> #define REG_RXINT_ROI_EN BIT(0)
> -/* Rx Packet End */
> +/* Rx Packet End Interrupt Enable */
> #define REG_RXINT_RPEI_EN BIT(1)
> -/* Rx FIFO Data Available */
> +/* Rx FIFO Data Available Interrupt Enable */
> #define REG_RXINT_RAI_EN BIT(4)
>
> /* Rx FIFO available byte level */
> @@ -60,6 +60,12 @@
>
> /* Rx Interrupt Status */
> #define SUNXI_IR_RXSTA_REG 0x30
> +/* Rx FIFO Overflow */
> +#define REG_RXSTA_ROI BIT(0)
> +/* Rx Packet End */
> +#define REG_RXSTA_RPE BIT(1)
> +/* Rx FIFO Data Available */
> +#define REG_RXSTA_RA BIT(4)
I'm fine with it on principle, but if the consistency needs to be
maintained then we could just reuse the above defines
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-05 9:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 16:29 [PATCH v4 00/13] Allwinner A64/H6 IR support Clément Péron
2019-06-04 16:29 ` [PATCH v4 01/13] dt-bindings: media: sunxi-ir: Add A31 compatible Clément Péron
2019-06-05 9:49 ` Maxime Ripard
2019-06-04 16:29 ` [PATCH v4 02/13] media: rc: Introduce sunxi_ir_quirks Clément Péron
2019-06-05 9:49 ` Maxime Ripard
2019-06-04 16:29 ` [PATCH v4 03/13] media: rc: sunxi: Add A31 compatible Clément Péron
2019-06-05 9:49 ` Maxime Ripard
2019-06-04 16:29 ` [PATCH v4 04/13] media: rc: sunxi: Add RXSTA bits definition Clément Péron
2019-06-05 9:51 ` Maxime Ripard [this message]
2019-06-05 12:44 ` Clément Péron
2019-06-05 20:00 ` Maxime Ripard
2019-06-05 20:34 ` Clément Péron
2019-06-04 16:29 ` [PATCH v4 05/13] ARM: dts: sunxi: Prefer A31 bindings for IR Clément Péron
2019-06-04 16:29 ` [PATCH v4 06/13] " Clément Péron
2019-06-04 16:29 ` [PATCH v4 07/13] dt-bindings: media: sunxi-ir: Add A64 compatible Clément Péron
2019-06-04 16:29 ` [PATCH v4 08/13] arm64: dts: allwinner: a64: Add IR node Clément Péron
2019-06-04 16:29 ` [PATCH v4 09/13] arm64: dts: allwinner: a64: Enable IR on Orange Pi Win Clément Péron
2019-06-04 16:29 ` [PATCH v4 10/13] dt-bindings: media: sunxi-ir: Add H6 compatible Clément Péron
2019-06-04 16:29 ` [PATCH v4 11/13] arm64: dts: allwinner: h6: Add IR receiver node Clément Péron
2019-06-04 16:29 ` [PATCH v4 12/13] arm64: dts: allwinner: h6: Enable IR on H6 boards Clément Péron
2019-06-04 16:29 ` [PATCH v4 13/13] arm64: defconfig: Enable IR SUNXI option Clément Péron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190605095141.psrq6mhk63zto77s@flea \
--to=maxime.ripard@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=peron.clem@gmail.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox