From: Sasha Levin <sashal@kernel.org>
To: Sinan Kaya <Okaya@kernel.org>
Cc: linux-kernel@microsoft.com, julien.thierry@arm.com,
marc.zyngier@arm.com, catalin.marinas@arm.com,
will.deacon@arm.com, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, stable@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM64/irqchip: Make ACPI_IORT depend on PCI again
Date: Tue, 16 Jul 2019 07:16:28 -0400 [thread overview]
Message-ID: <20190716111628.GB1943@sasha-vm> (raw)
In-Reply-To: <a688793b-f7e8-18a4-3eb2-877f1522d8f3@kernel.org>
On Tue, Jul 16, 2019 at 12:13:23AM -0400, Sinan Kaya wrote:
>On 7/16/2019 12:04 AM, Sasha Levin wrote:
>> ACPI_IORT lost it's explicit dependency on PCI in c6bb8f89fa6df
>> ("ARM64/irqchip: Update ACPI_IORT symbol selection logic") where the
>> author has relied on the general dependency of ACPI on PCI.
>>
>> However, that dependency was finally removed in 5d32a66541c4 ("PCI/ACPI:
>> Allow ACPI to be built without CONFIG_PCI set") and now ACPI_IORT breaks
>> when we try and build it without PCI support.
>>
>> This patch brings back the explicit dependency of ACPI_IORT on PCI.
>>
>> Fixes: 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
>> Cc: stable@kernel.org
>> Signed-off-by: Sasha Levin <sashal@kernel.org>
>
>Do you have more detail on what really is broken without this patch?
>
>It should be possible to build IORT table without PCI.
For the record, the errors look like this:
drivers/acpi/arm64/iort.o: In function `acpi_iort_init':
iort.c:(.init.text+0x47c): undefined reference to `pci_request_acs'
Sinan pointed me to an earlier patch he wrote that would fix it
(https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/acpi/arm64/iort.c?id=43554cebba50e709b9207c55ceca6bc281748586).
Please disregard this patch.
--
Thanks,
Sasha
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-07-16 11:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 4:04 [PATCH] ARM64/irqchip: Make ACPI_IORT depend on PCI again Sasha Levin
2019-07-16 4:13 ` Sinan Kaya
2019-07-16 11:16 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716111628.GB1943@sasha-vm \
--to=sashal@kernel.org \
--cc=Okaya@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=julien.thierry@arm.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=stable@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox