From: Maxime Ripard <mripard@kernel.org>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree <devicetree@vger.kernel.org>,
David Airlie <airlied@linux.ie>,
linux-sunxi <linux-sunxi@googlegroups.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
Daniel Vetter <daniel@ffwll.ch>,
Michael Trimarchi <michael@amarulasolutions.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Icenowy Zheng <icenowy@aosc.io>
Subject: Re: [PATCH v10 1/6] dt-bindings: sun6i-dsi: Add A64 MIPI-DSI compatible
Date: Mon, 14 Oct 2019 13:00:06 +0200 [thread overview]
Message-ID: <20191014110006.b324hccd52u7fotw@gilmour> (raw)
In-Reply-To: <CAMty3ZA1azP3kkJPw6oZudcSQksF6i+STeW=oOh65cfHsj0QrQ@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1703 bytes --]
On Sun, Oct 13, 2019 at 10:32:18PM +0530, Jagan Teki wrote:
> On Mon, Oct 7, 2019 at 3:01 PM Maxime Ripard <mripard@kernel.org> wrote:
> >
> > On Sat, Oct 05, 2019 at 07:49:08PM +0530, Jagan Teki wrote:
> > > The MIPI DSI controller in Allwinner A64 is similar to A33.
> > >
> > > But unlike A33, A64 doesn't have DSI_SCLK gating so it is valid
> > > to with separate compatible for A64 on the same driver.
> > >
> > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > ---
> > > .../bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml | 4 +++-
> > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml b/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml
> > > index dafc0980c4fa..cfcc84d38084 100644
> > > --- a/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml
> > > +++ b/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml
> > > @@ -15,7 +15,9 @@ properties:
> > > "#size-cells": true
> > >
> > > compatible:
> > > - const: allwinner,sun6i-a31-mipi-dsi
> > > + enum:
> > > + - const: allwinner,sun6i-a31-mipi-dsi
> > > + - const: allwinner,sun50i-a64-mipi-dsi
> >
> > How did you test this? It will report an error when running the
> > validation
>
> I did follow the v9 comments [1] and forgot to do dt-doc-validate.
> will send the v11 for this patch alone, will that be okay?
>
> [1] https://patchwork.freedesktop.org/patch/307499/
There's some changes to the DTSI to do as well, so please do them,
check that the device trees are validated properly, and send a new
version.
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-14 11:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-05 14:19 [PATCH v10 0/6] drm/sun4i: Allwinner A64 MIPI-DSI support Jagan Teki
2019-10-05 14:19 ` [PATCH v10 1/6] dt-bindings: sun6i-dsi: Add A64 MIPI-DSI compatible Jagan Teki
2019-10-07 9:31 ` Maxime Ripard
2019-10-13 17:02 ` Jagan Teki
2019-10-14 11:00 ` Maxime Ripard [this message]
2019-10-05 14:19 ` [PATCH v10 2/6] dt-bindings: sun6i-dsi: Add A64 DPHY compatible (w/ A31 fallback) Jagan Teki
2019-10-05 14:19 ` [PATCH v10 3/6] drm/sun4i: dsi: Add has_mod_clk quirk Jagan Teki
2019-10-05 14:19 ` [PATCH v10 4/6] drm/sun4i: dsi: Add Allwinner A64 MIPI DSI support Jagan Teki
2019-10-05 14:19 ` [PATCH v10 5/6] arm64: dts: allwinner: a64: Add MIPI DSI pipeline Jagan Teki
2019-10-07 10:57 ` Maxime Ripard
2019-10-14 12:07 ` Jagan Teki
2019-10-16 8:03 ` Maxime Ripard
2019-10-16 8:49 ` Jagan Teki
2019-10-17 9:52 ` Maxime Ripard
2019-10-24 7:58 ` Jagan Teki
2019-10-24 18:27 ` Maxime Ripard
2019-10-25 13:23 ` Jagan Teki
2019-10-24 12:56 ` Jagan Teki
2019-10-24 18:28 ` Maxime Ripard
2019-10-05 14:19 ` [DO NOT MERGE] [PATCH v10 6/6] arm64: dts: allwinner: bananapi-m64: Enable Bananapi S070WV20-CT16 DSI panel Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014110006.b324hccd52u7fotw@gilmour \
--to=mripard@kernel.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=icenowy@aosc.io \
--cc=jagan@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=michael@amarulasolutions.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox