From: Maxime Ripard <mripard@kernel.org>
To: Alistair Francis <alistair@alistair23.me>
Cc: alistair23@gmail.com, wens@csie.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: sun50i: sopine-baseboard: Expose serial1, serial2 and serial3
Date: Wed, 16 Oct 2019 16:49:46 +0200 [thread overview]
Message-ID: <20191016144946.p3tm67vh5lqigndn@gilmour> (raw)
In-Reply-To: <20191012200524.23512-1-alistair@alistair23.me>
[-- Attachment #1.1: Type: text/plain, Size: 1407 bytes --]
Hi,
On Sat, Oct 12, 2019 at 01:05:24PM -0700, Alistair Francis wrote:
> Follow what the sun50i-a64-pine64.dts does and expose all 5 serial
> connections.
>
> Signed-off-by: Alistair Francis <alistair@alistair23.me>
> ---
> .../allwinner/sun50i-a64-sopine-baseboard.dts | 25 +++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> index 124b0b030b28..49c37b21ab36 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> @@ -56,6 +56,10 @@
> aliases {
> ethernet0 = &emac;
> serial0 = &uart0;
> + serial1 = &uart1;
> + serial2 = &uart2;
> + serial3 = &uart3;
> + serial4 = &uart4;
> };
>
> chosen {
> @@ -280,6 +284,27 @@
> };
> };
>
> +/* On Pi-2 connector */
> +&uart2 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart2_pins>;
> + status = "disabled";
> +};
> +
> +/* On Euler connector */
> +&uart3 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart3_pins>;
> + status = "disabled";
> +};
> +
> +/* On Euler connector, RTS/CTS optional */
> +&uart4 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart4_pins>;
> + status = "disabled";
> +};
Since these are all the default muxing, maybe we should just set that
in the DTSI?
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-16 14:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-12 20:05 [PATCH] arm64: dts: sun50i: sopine-baseboard: Expose serial1, serial2 and serial3 Alistair Francis
2019-10-16 14:49 ` Maxime Ripard [this message]
2019-10-16 14:54 ` Chen-Yu Tsai
2019-10-16 16:10 ` Alistair Francis
2019-10-21 11:17 ` Maxime Ripard
2019-11-05 19:27 ` Alistair Francis
2019-11-06 11:52 ` Maxime Ripard
2019-11-06 21:45 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016144946.p3tm67vh5lqigndn@gilmour \
--to=mripard@kernel.org \
--cc=alistair23@gmail.com \
--cc=alistair@alistair23.me \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox