From: Will Deacon <will@kernel.org>
To: Candle Sun <candlesea@gmail.com>
Cc: mark.rutland@arm.com, linux@armlinux.org.uk,
Candle Sun <candle.sun@unisoc.com>,
linux-kernel@vger.kernel.org, Nianfu Bai <nianfu.bai@unisoc.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RESEND PATCH] ARM/hw_breakpoint: add ARMv8.1/ARMv8.2 debug architecutre versions support in enable_monitor_mode()
Date: Tue, 22 Oct 2019 13:25:50 +0100 [thread overview]
Message-ID: <20191022122550.GA17232@willie-the-truck> (raw)
In-Reply-To: <1569483508-18768-1-git-send-email-candlesea@gmail.com>
On Thu, Sep 26, 2019 at 03:38:28PM +0800, Candle Sun wrote:
> From: Candle Sun <candle.sun@unisoc.com>
>
> When ARMv8.1/ARMv8.2 cores are used in AArch32 mode,
> arch_hw_breakpoint_init() in arch/arm/kernel/hw_breakpoint.c will be used.
>
> From ARMv8 specification, different debug architecture versions defined:
> * 0110 ARMv8, v8 Debug architecture.
> * 0111 ARMv8.1, v8 Debug architecture, with Virtualization Host Extensions.
> * 1000 ARMv8.2, v8.2 Debug architecture.
>
> So missing ARMv8.1/ARMv8.2 cases will cause enable_monitor_mode() function
> returns -ENODEV, and arch_hw_breakpoint_init() will fail.
>
> Signed-off-by: Candle Sun <candle.sun@unisoc.com>
> Signed-off-by: Nianfu Bai <nianfu.bai@unisoc.com>
> ---
> arch/arm/include/asm/hw_breakpoint.h | 2 ++
> arch/arm/kernel/hw_breakpoint.c | 2 ++
> 2 files changed, 4 insertions(+)
[...]
> diff --git a/arch/arm/include/asm/hw_breakpoint.h b/arch/arm/include/asm/hw_breakpoint.h
> index ac54c06..9137ef6 100644
> --- a/arch/arm/include/asm/hw_breakpoint.h
> +++ b/arch/arm/include/asm/hw_breakpoint.h
> @@ -53,6 +53,8 @@ static inline void decode_ctrl_reg(u32 reg,
> #define ARM_DEBUG_ARCH_V7_MM 4
> #define ARM_DEBUG_ARCH_V7_1 5
> #define ARM_DEBUG_ARCH_V8 6
> +#define ARM_DEBUG_ARCH_V8_1 7
> +#define ARM_DEBUG_ARCH_V8_2 8
Looks like you can also add:
#define ARM_DEBUG_ARCH_V8_4 9
and treat that the same way. With that, and a fix to $SUBJECT:
Acked-by: Will Deacon <will@kernel.org>
Please put this into the patch system [1].
Will
[1] https://www.arm.linux.org.uk/developer/patches/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-22 12:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 7:38 [RESEND PATCH] ARM/hw_breakpoint: add ARMv8.1/ARMv8.2 debug architecutre versions support in enable_monitor_mode() Candle Sun
2019-09-30 15:34 ` Will Deacon
2019-10-08 7:20 ` Candle Sun
2019-10-11 5:56 ` Candle Sun
2019-10-11 5:59 ` Uwe Kleine-König
2019-10-11 6:53 ` Candle Sun
2019-10-22 12:25 ` Will Deacon [this message]
2019-10-22 12:37 ` Candle Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191022122550.GA17232@willie-the-truck \
--to=will@kernel.org \
--cc=candle.sun@unisoc.com \
--cc=candlesea@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=nianfu.bai@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox