public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH 1/3] ARM: dts: sunxi: h3/h5: add missing uart2 rts/cts pins
@ 2018-12-18 21:24 Karl Palsson
  0 siblings, 0 replies; 3+ messages in thread
From: Karl Palsson @ 2018-12-18 21:24 UTC (permalink / raw)
  To: robh+dt, mark.rutland, maxime.ripard, wens, devicetree,
	linux-kernel, linux-arm-kernel
  Cc: Karl Palsson

uart1 and uart3 had existing pin definitions for the rts/cts pairs.
Add definitions for uart2 as well.

Signed-off-by: Karl Palsson <karlp@tweak.net.au>
---
 arch/arm/boot/dts/sunxi-h3-h5.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
index a4c757c0b741..38d3deefa0e3 100644
--- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
+++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
@@ -472,6 +472,11 @@
 				function = "uart2";
 			};
 
+			uart2_rts_cts_pins: uart2_rts_cts {
+				pins = "PA2", "PA3";
+				function = "uart2";
+			};
+
 			uart3_pins: uart3 {
 				pins = "PA13", "PA14";
 				function = "uart3";
-- 
2.14.5


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/3] ARM: dts: sunxi: h3/h5: add missing uart2 rts/cts pins
       [not found] <20191031231104.30725-1-karlp@tweak.net.au>
@ 2019-11-01  2:42 ` Chen-Yu Tsai
  2019-11-01  9:05 ` Maxime Ripard
  1 sibling, 0 replies; 3+ messages in thread
From: Chen-Yu Tsai @ 2019-11-01  2:42 UTC (permalink / raw)
  To: Karl Palsson; +Cc: linux-arm-kernel, Maxime Ripard, linux-kernel

On Fri, Nov 1, 2019 at 7:16 AM Karl Palsson <karlp@tweak.net.au> wrote:
>
> uart1 and uart3 had existing pin definitions for the rts/cts pairs.
> Add definitions for uart2 as well.
>
> Signed-off-by: Karl Palsson <karlp@tweak.net.au>
> ---
>  arch/arm/boot/dts/sunxi-h3-h5.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> index 84977d4eb97a..2d8637300321 100644
> --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> @@ -472,6 +472,11 @@
>                                 function = "uart2";
>                         };
>
> +                       uart2_rts_cts_pins: uart2-rts-cts-pins {

We started adding "/omit-if-no-ref/" for all pin definitions that
aren't selected by default. I think we can do this wholesale for
all the ones in this file after this patch is merged though. So,

Acked-by: Chen-Yu Tsai <wens@csie.org>

> +                               pins = "PA2", "PA3";
> +                               function = "uart2";
> +                       };
> +
>                         uart3_pins: uart3-pins {
>                                 pins = "PA13", "PA14";
>                                 function = "uart3";
> --
> 2.20.1
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/3] ARM: dts: sunxi: h3/h5: add missing uart2 rts/cts pins
       [not found] <20191031231104.30725-1-karlp@tweak.net.au>
  2019-11-01  2:42 ` [PATCH 1/3] ARM: dts: sunxi: h3/h5: add missing uart2 rts/cts pins Chen-Yu Tsai
@ 2019-11-01  9:05 ` Maxime Ripard
  1 sibling, 0 replies; 3+ messages in thread
From: Maxime Ripard @ 2019-11-01  9:05 UTC (permalink / raw)
  To: Karl Palsson; +Cc: wens, linux-kernel, linux-arm-kernel


[-- Attachment #1.1: Type: text/plain, Size: 247 bytes --]

On Thu, Oct 31, 2019 at 11:11:02PM +0000, Karl Palsson wrote:
> uart1 and uart3 had existing pin definitions for the rts/cts pairs.
> Add definitions for uart2 as well.
>
> Signed-off-by: Karl Palsson <karlp@tweak.net.au>

Applied, thanks!
Maxime

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-11-01  9:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20191031231104.30725-1-karlp@tweak.net.au>
2019-11-01  2:42 ` [PATCH 1/3] ARM: dts: sunxi: h3/h5: add missing uart2 rts/cts pins Chen-Yu Tsai
2019-11-01  9:05 ` Maxime Ripard
2018-12-18 21:24 Karl Palsson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox