* [PATCH -next] media: sun8i: Remove redundant dev_err call in deinterlace_probe()
@ 2019-11-06 15:32 Wei Yongjun
2019-11-06 15:59 ` Jernej Škrabec
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2019-11-06 15:32 UTC (permalink / raw)
To: Jernej Skrabec, Mauro Carvalho Chehab, Maxime Ripard,
Chen-Yu Tsai, Philipp Zabel
Cc: kernel-janitors, Wei Yongjun, linux-arm-kernel, linux-media
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/media/platform/sunxi/sun8i-di/sun8i-di.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/media/platform/sunxi/sun8i-di/sun8i-di.c b/drivers/media/platform/sunxi/sun8i-di/sun8i-di.c
index aaa1dc159ac2..b61f3dea7c93 100644
--- a/drivers/media/platform/sunxi/sun8i-di/sun8i-di.c
+++ b/drivers/media/platform/sunxi/sun8i-di/sun8i-di.c
@@ -834,11 +834,8 @@ static int deinterlace_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
dev->base = devm_ioremap_resource(&pdev->dev, res);
- if (IS_ERR(dev->base)) {
- dev_err(dev->dev, "Failed to map registers\n");
-
+ if (IS_ERR(dev->base))
return PTR_ERR(dev->base);
- }
dev->bus_clk = devm_clk_get(dev->dev, "bus");
if (IS_ERR(dev->bus_clk)) {
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next] media: sun8i: Remove redundant dev_err call in deinterlace_probe()
2019-11-06 15:32 [PATCH -next] media: sun8i: Remove redundant dev_err call in deinterlace_probe() Wei Yongjun
@ 2019-11-06 15:59 ` Jernej Škrabec
0 siblings, 0 replies; 2+ messages in thread
From: Jernej Škrabec @ 2019-11-06 15:59 UTC (permalink / raw)
To: Wei Yongjun
Cc: kernel-janitors, Maxime Ripard, Chen-Yu Tsai, Philipp Zabel,
Mauro Carvalho Chehab, linux-arm-kernel, linux-media
Hi!
Dne sreda, 06. november 2019 ob 16:32:12 CET je Wei Yongjun napisal(a):
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Jernej Skrabec <jernej.skrabec@siol.net>
Best regards,
Jernej
> ---
> drivers/media/platform/sunxi/sun8i-di/sun8i-di.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/media/platform/sunxi/sun8i-di/sun8i-di.c
> b/drivers/media/platform/sunxi/sun8i-di/sun8i-di.c index
> aaa1dc159ac2..b61f3dea7c93 100644
> --- a/drivers/media/platform/sunxi/sun8i-di/sun8i-di.c
> +++ b/drivers/media/platform/sunxi/sun8i-di/sun8i-di.c
> @@ -834,11 +834,8 @@ static int deinterlace_probe(struct platform_device
> *pdev)
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> dev->base = devm_ioremap_resource(&pdev->dev, res);
> - if (IS_ERR(dev->base)) {
> - dev_err(dev->dev, "Failed to map registers\n");
> -
> + if (IS_ERR(dev->base))
> return PTR_ERR(dev->base);
> - }
>
> dev->bus_clk = devm_clk_get(dev->dev, "bus");
> if (IS_ERR(dev->bus_clk)) {
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-06 16:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-06 15:32 [PATCH -next] media: sun8i: Remove redundant dev_err call in deinterlace_probe() Wei Yongjun
2019-11-06 15:59 ` Jernej Škrabec
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox