From: Will Deacon <will@kernel.org>
To: Catalin Marinas <catalin.marinas@arm.com>, steve.capper@arm.com
Cc: John Stultz <john.stultz@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: Do not mask out PTE_RDONLY in pte_same()
Date: Thu, 7 Nov 2019 11:48:26 +0000 [thread overview]
Message-ID: <20191107114826.GC11587@willie-the-truck> (raw)
In-Reply-To: <20191106154105.15176-1-catalin.marinas@arm.com>
On Wed, Nov 06, 2019 at 03:41:05PM +0000, Catalin Marinas wrote:
> Following commit 73e86cb03cf2 ("arm64: Move PTE_RDONLY bit handling out
> of set_pte_at()"), the PTE_RDONLY bit is no longer managed by
> set_pte_at() but built into the PAGE_* attribute definitions.
> Consequently, pte_same() must include this bit when checking two PTEs
> for equality.
>
> Remove the arm64-specific pte_same() function, practically reverting
> commit 747a70e60b72 ("arm64: Fix copy-on-write referencing in HugeTLB")
>
> Fixes: 73e86cb03cf2 ("arm64: Move PTE_RDONLY bit handling out of set_pte_at()")
> Cc: <stable@vger.kernel.org> # 4.14.x-
> Cc: Will Deacon <will@kernel.org>
> Cc: Steve Capper <steve.capper@arm.com>
> Reported-by: John Stultz <john.stultz@linaro.org>
> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
> ---
>
> Steve,
>
> Could you please check that the original problem fixed by commit
> 747a70e60b72 no longer exists after reverting it in 4.14 onwards?
In the meantime, I've pushed this out to for-next/fixes since the CI came
back clean and it fixes John's issue (which I've confirmed locally too).
Interestingly, I'm not at all sure the problem is related to the Mali
driver. Some tracing suggests that the ART JIT thread is stuck on a write
fault, which could be explained by a broken pte_same().
Steve -- if you could please run the libhugetlbfs test suite as described
in 747a70e60b72 before tomorrow, that would be really great.
Thanks,
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-07 11:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 15:41 [PATCH] arm64: Do not mask out PTE_RDONLY in pte_same() Catalin Marinas
2019-11-06 16:12 ` Will Deacon
2019-11-07 11:48 ` Will Deacon [this message]
2019-11-08 2:08 ` Steve Capper
2019-11-08 2:37 ` Steve Capper
2019-11-08 9:40 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191107114826.GC11587@willie-the-truck \
--to=will@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=john.stultz@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=steve.capper@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox