From: Dan Carpenter <dan.carpenter@linaro.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Prasad Pandit <ppandit@redhat.com>,
florian.fainelli@broadcom.com,
bcm-kernel-feedback-list@broadcom.com,
linux-arm-kernel@lists.infradead.org, rjui@broadcom.com,
sbranden@broadcom.com, linux-staging@lists.linux.dev,
linux-rpi-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Prasad Pandit <pjp@fedoraproject.org>
Subject: Re: [PATCH v3] staging: bcm2835-audio: add terminating new line to Kconfig
Date: Mon, 25 Mar 2024 22:42:35 +0300 [thread overview]
Message-ID: <201b6c82-1ebf-4dc2-9221-4fc87d1dd565@moroto.mountain> (raw)
In-Reply-To: <2024032540-scrubbed-reluctant-8860@gregkh>
On Mon, Mar 25, 2024 at 07:04:15PM +0100, Greg KH wrote:
> On Wed, Mar 13, 2024 at 05:11:26PM +0530, Prasad Pandit wrote:
> > From: Prasad Pandit <pjp@fedoraproject.org>
> >
> > Add terminating new line to the Kconfig file. It helps
> > Kconfig parsers to read file without error.
>
> What in-tree parser has a problem with this file as-is? If it's an
> out-of-tree parser, that's different, and the tool should be fixed, no
> need to touch the kernel files for no good reason.
It's annoying to cat a file when it doesn't have a newline on the end...
dcarpenter@moroto:~/progs/kernel/trees$ cat -n drivers/staging/vc04_services/bcm2835-audio/Kconfig
1 # SPDX-License-Identifier: GPL-2.0
2 config SND_BCM2835
3 tristate "BCM2835 Audio"
4 depends on (ARCH_BCM2835 || COMPILE_TEST) && SND
5 select SND_PCM
6 select BCM2835_VCHIQ if HAS_DMA
7 help
8 Say Y or M if you want to support BCM2835 built in audio.
9 This driver handles both 3.5mm and HDMI audio, by leveraging
10 the VCHIQ messaging interface between the kernel and the firmware
11 running on VideoCore.dcarpenter@moroto:~/progs/kernel/trees$
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
So you could resend with that as a justification. But, yeah, it's a
good idea to fix the tool as well.
regards,
dan carpenter
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-25 19:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 11:41 [PATCH v3] staging: bcm2835-audio: add terminating new line to Kconfig Prasad Pandit
2024-03-13 11:55 ` Dan Carpenter
2024-03-25 18:04 ` Greg KH
2024-03-25 19:42 ` Dan Carpenter [this message]
2024-03-26 9:45 ` Prasad Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201b6c82-1ebf-4dc2-9221-4fc87d1dd565@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=florian.fainelli@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=pjp@fedoraproject.org \
--cc=ppandit@redhat.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox