From: Will Deacon <will@kernel.org>
To: AKASHI Takahiro <takahiro.akashi@linaro.org>,
pasha.tatashin@soleen.com, catalin.marinas@arm.com,
will.deacon@arm.com, robh+dt@kernel.org, frowand.list@gmail.com,
bhsharma@redhat.com, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org, james.morse@arm.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 2/2] arm64: kexec_file: add crash dump support
Date: Fri, 10 Jan 2020 16:05:49 +0000 [thread overview]
Message-ID: <20200110160549.GA25437@willie-the-truck> (raw)
In-Reply-To: <20200109083254.GA7280@willie-the-truck>
On Thu, Jan 09, 2020 at 08:32:54AM +0000, Will Deacon wrote:
> On Thu, Jan 09, 2020 at 09:46:55AM +0900, AKASHI Takahiro wrote:
> > On Wed, Jan 08, 2020 at 05:48:39PM +0000, Will Deacon wrote:
> > > On Mon, Dec 16, 2019 at 11:12:47AM +0900, AKASHI Takahiro wrote:
> > > > diff --git a/arch/arm64/include/asm/kexec.h b/arch/arm64/include/asm/kexec.h
> > > > index 12a561a54128..d24b527e8c00 100644
> > > > --- a/arch/arm64/include/asm/kexec.h
> > > > +++ b/arch/arm64/include/asm/kexec.h
> > > > @@ -96,6 +96,10 @@ static inline void crash_post_resume(void) {}
> > > > struct kimage_arch {
> > > > void *dtb;
> > > > unsigned long dtb_mem;
> > > > + /* Core ELF header buffer */
> > > > + void *elf_headers;
> > > > + unsigned long elf_headers_mem;
> > > > + unsigned long elf_headers_sz;
> > > > };
> > >
> > > This conflicts with the cleanup work from Pavel. Please can you check my
> > > resolution? [1]
> >
> > I don't know why we need to change a type of dtb_mem,
> > otherwise it looks good.
> >
> > (I also assume that you notice that kimage_arch is of no use for kexec.)
>
> Yes, that's why I'd like the resolution checked. If you reckon it's cleaner
> to drop Pavel's patch altogether in light of your changes, we can do that
> instead.
>
> Thoughts?
Well, I've reverted the cleanup patch so please shout if you'd prefer
something else.
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-10 16:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 2:12 [PATCH v4 0/2] arm64: kexec_file: add kdump AKASHI Takahiro
2019-12-16 2:12 ` [PATCH v4 1/2] libfdt: include fdt_addresses.c AKASHI Takahiro
2019-12-16 2:12 ` [PATCH v4 2/2] arm64: kexec_file: add crash dump support AKASHI Takahiro
2020-01-08 17:48 ` Will Deacon
2020-01-08 17:58 ` Pavel Tatashin
2020-01-09 0:46 ` AKASHI Takahiro
2020-01-09 8:32 ` Will Deacon
2020-01-10 16:05 ` Will Deacon [this message]
2020-01-10 16:19 ` Pavel Tatashin
2020-01-13 11:21 ` Will Deacon
2020-01-14 5:38 ` AKASHI Takahiro
2020-01-16 18:08 ` Will Deacon
2020-01-17 6:38 ` AKASHI Takahiro
2020-01-17 12:45 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200110160549.GA25437@willie-the-truck \
--to=will@kernel.org \
--cc=bhsharma@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=frowand.list@gmail.com \
--cc=james.morse@arm.com \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pasha.tatashin@soleen.com \
--cc=robh+dt@kernel.org \
--cc=takahiro.akashi@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox