From: Catalin Marinas <catalin.marinas@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org,
"kernelci.org bot" <bot@kernelci.org>,
kernel-build-reports@lists.linaro.org
Subject: Re: arm64/for-kernelci build: 3 builds: 1 failed, 2 passed, 1 error (v5.6-rc6-67-gcf89e8c383a6)
Date: Wed, 18 Mar 2020 12:23:04 +0000 [thread overview]
Message-ID: <20200318122304.GB94111@arrakis.emea.arm.com> (raw)
In-Reply-To: <20200318121627.GC4553@sirena.org.uk>
On Wed, Mar 18, 2020 at 12:16:27PM +0000, Mark Brown wrote:
> On Wed, Mar 18, 2020 at 12:06:14PM +0000, Catalin Marinas wrote:
>
> > If ARCH_USE_GNU_PROPERTY is specific to ELF only, I'd rather not select
> > it unconditionally (and the option should probably depend on
> > BINFMT_ELF). Following the pattern of ARCH_HAVE_EXTRA_ELF_NOTES, we
> > could fix it up as below:
> >
> > diff --git a/arch/arm64/include/asm/elf.h b/arch/arm64/include/asm/elf.h
> > index 4f00d50585a4..2eef3672de50 100644
> > --- a/arch/arm64/include/asm/elf.h
> > +++ b/arch/arm64/include/asm/elf.h
> > @@ -238,6 +238,7 @@ struct arch_elf_state {
> > .flags = 0, \
> > }
> >
> > +#ifdef CONFIG_ARCH_USE_GNU_PROPERTY
>
> That makes sense to me.
>
> > +#endif
> >
> > static inline int arch_elf_pt_proc(void *ehdr, void *phdr,
> > struct file *f, bool is_interp,
>
> Though presumably this is all eventually dead code too?
I'll let you pick one ;), I don't have a strong preference either way.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-18 12:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 23:15 arm64/for-kernelci build: 3 builds: 1 failed, 2 passed, 1 error (v5.6-rc6-67-gcf89e8c383a6) kernelci.org bot
2020-03-18 8:28 ` Will Deacon
2020-03-18 12:06 ` Catalin Marinas
2020-03-18 12:16 ` Mark Brown
2020-03-18 12:23 ` Catalin Marinas [this message]
2020-03-18 12:26 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318122304.GB94111@arrakis.emea.arm.com \
--to=catalin.marinas@arm.com \
--cc=bot@kernelci.org \
--cc=broonie@kernel.org \
--cc=kernel-build-reports@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox