From: Will Deacon <will@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/3] arm64: insn: Report PAC and BTI instructions as NOPs
Date: Thu, 30 Apr 2020 18:20:40 +0100 [thread overview]
Message-ID: <20200430172039.GJ25258@willie-the-truck> (raw)
In-Reply-To: <20200430171645.GG4633@sirena.org.uk>
On Thu, Apr 30, 2020 at 06:16:45PM +0100, Mark Brown wrote:
> On Thu, Apr 30, 2020 at 05:09:29PM +0100, Will Deacon wrote:
> > On Tue, Apr 28, 2020 at 06:24:33PM +0100, Mark Brown wrote:
>
> > > + /*
> > > + * The PAC and BTI instructons are not strictly NOPs but until
> > > + * better support is added we can treat them as such.
> > > + */
> > > switch (insn & 0xFE0) {
>
> > Are you deliberately omitting XPACLRI? If so, maybe add a comment to say
> > why, since it looks a bit weird without it.
>
> Not deliberately, no - I'm not sure I'd heard of it before and it's one
> of those cases where the spec doesn't call out the instruction as being
> in the hint space.
Hmm, so I only spotted it because of "Decode" pseudocode for HINT on p.929
of rev F.a of the Arm ARM (the one with the AUTHASP typo).
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-30 17:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 17:24 [PATCH v2 0/3] arm64: Make NOP handling a whitelist Mark Brown
2020-04-28 17:24 ` [PATCH v2 1/3] arm64: insn: Don't assume unrecognized HINTs are NOPs Mark Brown
2020-04-30 16:08 ` Will Deacon
2020-04-28 17:24 ` [PATCH v2 2/3] arm64: insn: Add constants for PAC and BTI instruction decode Mark Brown
2020-04-30 16:07 ` Will Deacon
2020-04-30 16:45 ` Mark Brown
2020-04-28 17:24 ` [PATCH v2 3/3] arm64: insn: Report PAC and BTI instructions as NOPs Mark Brown
2020-04-30 16:09 ` Will Deacon
2020-04-30 17:16 ` Mark Brown
2020-04-30 17:20 ` Will Deacon [this message]
2020-04-30 17:36 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200430172039.GJ25258@willie-the-truck \
--to=will@kernel.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox