* [PATCH] clk / soc: mediatek: fix ptr_ret.cocci warnings [not found] <202005101033.xLBIJF9V%lkp@intel.com> @ 2020-05-10 2:53 ` kbuild test robot 2020-05-10 10:07 ` Enric Balletbo i Serra 0 siblings, 1 reply; 3+ messages in thread From: kbuild test robot @ 2020-05-10 2:53 UTC (permalink / raw) To: Matthias Brugger Cc: kbuild-all, Stephen Boyd, linux-kernel, CK Hu, linux-mediatek, Enric Balletbo i Serra, linux-arm-kernel From: kbuild test robot <lkp@intel.com> drivers/soc/mediatek/mtk-mmsys.c:28:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: 13032709e232 ("clk / soc: mediatek: Move mt8173 MMSYS to platform driver") CC: Matthias Brugger <mbrugger@suse.com> Signed-off-by: kbuild test robot <lkp@intel.com> --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 30e2206e11ce27ae910cc0dab21472429e400a87 commit: 13032709e2328553970f0002df5edce6aac69425 [1266/7905] clk / soc: mediatek: Move mt8173 MMSYS to platform driver mtk-mmsys.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/drivers/soc/mediatek/mtk-mmsys.c +++ b/drivers/soc/mediatek/mtk-mmsys.c @@ -25,10 +25,7 @@ static int mtk_mmsys_probe(struct platfo clks = platform_device_register_data(&pdev->dev, data->clk_driver, PLATFORM_DEVID_AUTO, NULL, 0); - if (IS_ERR(clks)) - return PTR_ERR(clks); - - return 0; + return PTR_ERR_OR_ZERO(clks); } static const struct of_device_id of_match_mtk_mmsys[] = { _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk / soc: mediatek: fix ptr_ret.cocci warnings 2020-05-10 2:53 ` [PATCH] clk / soc: mediatek: fix ptr_ret.cocci warnings kbuild test robot @ 2020-05-10 10:07 ` Enric Balletbo i Serra 2020-05-15 11:20 ` Matthias Brugger 0 siblings, 1 reply; 3+ messages in thread From: Enric Balletbo i Serra @ 2020-05-10 10:07 UTC (permalink / raw) To: kbuild test robot, Matthias Brugger Cc: kbuild-all, Stephen Boyd, linux-kernel, linux-mediatek, CK Hu, linux-arm-kernel On 10/5/20 4:53, kbuild test robot wrote: > From: kbuild test robot <lkp@intel.com> > > drivers/soc/mediatek/mtk-mmsys.c:28:1-3: WARNING: PTR_ERR_OR_ZERO can be used > > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Generated by: scripts/coccinelle/api/ptr_ret.cocci > > Fixes: 13032709e232 ("clk / soc: mediatek: Move mt8173 MMSYS to platform driver") > CC: Matthias Brugger <mbrugger@suse.com> > Signed-off-by: kbuild test robot <lkp@intel.com> Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > --- > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 30e2206e11ce27ae910cc0dab21472429e400a87 > commit: 13032709e2328553970f0002df5edce6aac69425 [1266/7905] clk / soc: mediatek: Move mt8173 MMSYS to platform driver > > mtk-mmsys.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > --- a/drivers/soc/mediatek/mtk-mmsys.c > +++ b/drivers/soc/mediatek/mtk-mmsys.c > @@ -25,10 +25,7 @@ static int mtk_mmsys_probe(struct platfo > > clks = platform_device_register_data(&pdev->dev, data->clk_driver, > PLATFORM_DEVID_AUTO, NULL, 0); > - if (IS_ERR(clks)) > - return PTR_ERR(clks); > - > - return 0; > + return PTR_ERR_OR_ZERO(clks); > } > > static const struct of_device_id of_match_mtk_mmsys[] = { > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk / soc: mediatek: fix ptr_ret.cocci warnings 2020-05-10 10:07 ` Enric Balletbo i Serra @ 2020-05-15 11:20 ` Matthias Brugger 0 siblings, 0 replies; 3+ messages in thread From: Matthias Brugger @ 2020-05-15 11:20 UTC (permalink / raw) To: Enric Balletbo i Serra, kbuild test robot Cc: kbuild-all, Stephen Boyd, linux-kernel, linux-mediatek, CK Hu, linux-arm-kernel On 10/05/2020 12:07, Enric Balletbo i Serra wrote: > > > On 10/5/20 4:53, kbuild test robot wrote: >> From: kbuild test robot <lkp@intel.com> >> >> drivers/soc/mediatek/mtk-mmsys.c:28:1-3: WARNING: PTR_ERR_OR_ZERO can be used >> >> >> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR >> >> Generated by: scripts/coccinelle/api/ptr_ret.cocci >> >> Fixes: 13032709e232 ("clk / soc: mediatek: Move mt8173 MMSYS to platform driver") >> CC: Matthias Brugger <mbrugger@suse.com> >> Signed-off-by: kbuild test robot <lkp@intel.com> > > Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > Since we have 667c769246b0 ("soc / drm: mediatek: Fix mediatek-drm device probing") I think this is not a valid patch anymore. Regards, Matthias >> --- >> >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master >> head: 30e2206e11ce27ae910cc0dab21472429e400a87 >> commit: 13032709e2328553970f0002df5edce6aac69425 [1266/7905] clk / soc: mediatek: Move mt8173 MMSYS to platform driver >> >> mtk-mmsys.c | 5 +---- >> 1 file changed, 1 insertion(+), 4 deletions(-) >> >> --- a/drivers/soc/mediatek/mtk-mmsys.c >> +++ b/drivers/soc/mediatek/mtk-mmsys.c >> @@ -25,10 +25,7 @@ static int mtk_mmsys_probe(struct platfo >> >> clks = platform_device_register_data(&pdev->dev, data->clk_driver, >> PLATFORM_DEVID_AUTO, NULL, 0); >> - if (IS_ERR(clks)) >> - return PTR_ERR(clks); >> - >> - return 0; >> + return PTR_ERR_OR_ZERO(clks); >> } >> >> static const struct of_device_id of_match_mtk_mmsys[] = { >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-15 11:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <202005101033.xLBIJF9V%lkp@intel.com>
2020-05-10 2:53 ` [PATCH] clk / soc: mediatek: fix ptr_ret.cocci warnings kbuild test robot
2020-05-10 10:07 ` Enric Balletbo i Serra
2020-05-15 11:20 ` Matthias Brugger
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox