[xlnx:master 9537/10031] drivers/spi/spi-mem.c:18:6: sparse: sparse: symbol 'update_stripe' was not declared. Should it be

[xlnx:master 9537/10031] drivers/spi/spi-mem.c:18:6: sparse: sparse: symbol 'update_stripe' was not declared. Should it be

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1022 bytes --]

tree:   https://github.com/Xilinx/linux-xlnx master
head:   3e983e4f0dfe5024dd0b4fedd5e46363f1dc9240
commit: 6cac93c63316f23909509a2894c5aba52d20a397 [9537/10031] spi: Add Zynq QSPI controller driver
config: i386-randconfig-s001-20200603 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-244-g0ee050a8-dirty
        git checkout 6cac93c63316f23909509a2894c5aba52d20a397
        # save the attached .config to linux build tree
        make W=1 C=1 ARCH=i386 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> drivers/spi/spi-mem.c:18:6: sparse: sparse: symbol 'update_stripe' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 35195 bytes --]

[-- Attachment #3: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[RFC PATCH xlnx] spi: update_stripe() can be static

[kernel test robot]

Fixes: 6cac93c63316 ("spi: Add Zynq QSPI controller driver")
Signed-off-by: kernel test robot <lkp@intel.com>
---
 spi-mem.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-mem.c b/drivers/spi/spi-mem.c
index d4e807c8263a4..b95a7fd0bee2d 100644
--- a/drivers/spi/spi-mem.c
+++ b/drivers/spi/spi-mem.c
@@ -15,7 +15,7 @@
 
 #define SPI_MEM_MAX_BUSWIDTH		8
 
-bool update_stripe(const u8 opcode)
+static bool update_stripe(const u8 opcode)
 {
 	if (opcode ==  SPINOR_OP_BE_4K ||
 	    opcode ==  SPINOR_OP_BE_32K ||

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel