From: Will Deacon <will@kernel.org>
To: Kevin Hao <haokexin@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
catalin.marinas@arm.com, kernel-team@android.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/2] arm64: Fix the call trace when running kgdb test suite
Date: Thu, 9 Jul 2020 14:03:48 +0100 [thread overview]
Message-ID: <20200709130346.GC28772@willie-the-truck> (raw)
In-Reply-To: <20200709125504.GA244448@pek-khao-d2.corp.ad.wrs.com>
On Thu, Jul 09, 2020 at 08:55:04PM +0800, Kevin Hao wrote:
> On Wed, Jul 08, 2020 at 11:02:34PM +0100, Will Deacon wrote:
> > On Fri, 17 Apr 2020 18:32:10 +0800, Kevin Hao wrote:
> > > This fixes a call trace when running the kgdb test suite:
> > > # echo kgdbts=V1 > /sys/module/kgdbts/parameters/kgdbts
> > >
> > > v2:
> > > - Add a patch to fix a typo in el1_dbg()
> > > - Use the method as suggested by Mark.
> > >
> > > [...]
> >
> > Applied to arm64 (for-next/fixes), thanks!
> >
> > [1/1] arm64: entry: Fix the typo in the comment of el1_dbg()
> > https://git.kernel.org/arm64/c/b8c1c9fe6a04
>
> How about patch 2 ("arm64: debug: Always update the IRQ tracing in debug_exception_enter())"?
> It has been dangled in the mail list for almost 3 months without any explicitly objections.
No, sorry, I really think it's the wrong direction of travel. Its adding
bodges to try to handle the fact that we disabled interrupts during the
step, and we really shouldn't be doing that (See my reply to Doug).
As I said, I would prefer some feedback on my proposal for dealing with
this properly [1] rather than more futile attempts to build on top of the
mess that we have at the moment.
Will
[1] https://lore.kernel.org/r/20200626095551.GA9312@willie-the-truck
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-07-09 13:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 10:32 [PATCH v2 0/2] arm64: Fix the call trace when running kgdb test suite Kevin Hao
2020-04-17 10:32 ` [PATCH 1/2] arm64: entry: Fix the typo in the comment of el1_dbg() Kevin Hao
2020-04-17 14:10 ` Mark Rutland
2020-04-17 10:32 ` [PATCH 2/2] arm64: debug: Always update the IRQ tracing in debug_exception_enter() Kevin Hao
2020-07-02 9:40 ` [PATCH v2 0/2] arm64: Fix the call trace when running kgdb test suite Kevin Hao
2020-07-08 22:02 ` Will Deacon
2020-07-09 12:55 ` Kevin Hao
2020-07-09 13:03 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200709130346.GC28772@willie-the-truck \
--to=will@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=haokexin@gmail.com \
--cc=kernel-team@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox