Re: [PATCH] MAINTAINERS: Add entries for CoreSight and Arm SPE

From: Will Deacon <will@kernel.org>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	John Garry <john.garry@huawei.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Leo Yan <leo.yan@linaro.org>, Jiri Olsa <jolsa@redhat.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] MAINTAINERS: Add entries for CoreSight and Arm SPE
Date: Wed, 19 Aug 2020 18:30:50 +0100	[thread overview]
Message-ID: <20200819173050.GA18091@willie-the-truck> (raw)
In-Reply-To: <CANLsYkw2aBJmrHV+8_bDUtgD-Jfvndqz2kOfNNcBBMM+vztkug@mail.gmail.com>

On Wed, Aug 19, 2020 at 11:01:38AM -0600, Mathieu Poirier wrote:
> On Tue, 18 Aug 2020 at 11:56, John Garry <john.garry@huawei.com> wrote:
> > On 17/08/2020 20:31, Mathieu Poirier wrote:
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 4e2698cc7e23..f9bb76baeec9 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -13427,8 +13427,18 @@ F:   tools/perf/
> > >   PERFORMANCE EVENTS SUBSYSTEM ARM64 PMU EVENTS
> > >   R:  John Garry <john.garry@huawei.com>
> > >   R:  Will Deacon <will@kernel.org>
> > > +R:   Mathieu Poirier <mathieu.poirier@linaro.org>
> > > +R:   Leo Yan <leo.yan@linaro.org>
> > >   L:  linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> > >   S:  Supported
> > > +F:   tools/build/feature/test-libopencsd.c
> > > +F:   tools/perf/arch/arm/util/auxtrace.c
> > > +F:   tools/perf/arch/arm/util/cs-etm.*
> > > +F:   tools/perf/arch/arm/util/pmu.c
> > > +F:   tools/perf/arch/arm64/util/arm-spe.c
> > > +F:   tools/perf/util/arm-spe.h
> > > +F:   tools/perf/util/cs-etm-decoder/*
> > > +F:   tools/perf/util/cs-etm.*
> >
> > But from the previous discussion, I thought that we wanted an entry to
> > cover all tools/perf/arch/arm64/ and other related folders. Or was it
> > just put all special interest parts (like SPE support) under one entry
> > and leave the other arm/arm64 parts to be caught by "PERFORMANCE EVENTS
> > SUBSYSTEM" entry?
> 
> I do not have the time to maintain anything outside of coresight -
> listing individual files as I did removes any ambiguity on that front.
> I'm happy to add tools/perf/arch/arm and tools/perf/arch/arm64/ if you
> agree to maintain them.  In that case you will have to be more
> specific about the "other related folders" you are referring to above.

None of us have time for this, hence why I think putting us all in one entry
with all of the files listed there makes the most sense; then people do
whatever they can and try to help each other out based on how much time they
have. I think that's much better than fine-grained maintainership where a
given file has a single point of failure.

So I think it should include:

  tools/perf/arch/arm64/
  tools/pmu-events/arch/arm64/

along with the SPE and Coresight files.

Arnaldo would still handle the patches, so this is really about giving us a
chance to review incoming patches without having to fish them out from the
lists.

Will

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel