From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: "Kévin L'hôpital" <kevin.lhopital@bootlin.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
p.zabel@pengutronix.de, thomas.petazzoni@bootlin.com,
linux-kernel@vger.kernel.org, mripard@kernel.org,
paul.kocialkowski@bootlin.com, wens@csie.org, robh+dt@kernel.org,
hans.verkuil@cisco.com, yong.deng@magewell.com,
mchehab+samsung@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v2 2/4] media: sunxi: sun6i-csi: Move the sun6i_csi_dev structure to the common header
Date: Mon, 31 Aug 2020 13:48:47 +0300 [thread overview]
Message-ID: <20200831104847.GJ31019@paasikivi.fi.intel.com> (raw)
In-Reply-To: <20200828131737.12483-3-kevin.lhopital@bootlin.com>
Hi Kévin,
On Fri, Aug 28, 2020 at 03:17:34PM +0200, Kévin L'hôpital wrote:
> Access to the sun6i_csi_dev structure is needed to add the
> MIPI CSI2 support.
>
> Signed-off-by: Kévin L'hôpital <kevin.lhopital@bootlin.com>
> ---
> drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c | 12 ------------
> drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h | 12 ++++++++++++
> 2 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
> index 055eb0b8e396..680fa31f380a 100644
> --- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
> +++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
> @@ -29,18 +29,6 @@
>
> #define MODULE_NAME "sun6i-csi"
>
> -struct sun6i_csi_dev {
> - struct sun6i_csi csi;
> - struct device *dev;
> -
> - struct regmap *regmap;
> - struct clk *clk_mod;
> - struct clk *clk_ram;
> - struct reset_control *rstc_bus;
> -
> - int planar_offset[3];
> -};
> -
> static inline struct sun6i_csi_dev *sun6i_csi_to_dev(struct sun6i_csi *csi)
> {
> return container_of(csi, struct sun6i_csi_dev, csi);
> diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h
> index 8b83d15de0d0..c4a87bdab8c3 100644
> --- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h
> +++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h
> @@ -48,6 +48,18 @@ struct sun6i_csi {
> struct sun6i_video video;
> };
>
> +struct sun6i_csi_dev {
> + struct sun6i_csi csi;
> + struct device *dev;
> + struct regmap *regmap;
> + struct clk *clk_mod;
> + struct clk *clk_ram;
> + struct clk *clk_mipi;
> + struct clk *clk_misc;
This patch adds two more clocks, please add them when you need them. I
think you could also squash the patch to another one that requires the
struct in the header.
> + struct reset_control *rstc_bus;
> + int planar_offset[3];
> +};
> +
> /**
> * sun6i_csi_is_format_supported() - check if the format supported by csi
> * @csi: pointer to the csi
--
Sakari Ailus
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-31 10:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 13:17 [PATCH v2 0/4] Support of MIPI CSI-2 for A83T Kévin L'hôpital
2020-08-28 13:17 ` [PATCH v2 1/4] media: sun6i-csi: Fix the bpp for 10-bit bayer formats Kévin L'hôpital
2020-08-31 10:47 ` Sakari Ailus
2020-08-28 13:17 ` [PATCH v2 2/4] media: sunxi: sun6i-csi: Move the sun6i_csi_dev structure to the common header Kévin L'hôpital
2020-08-31 10:48 ` Sakari Ailus [this message]
2020-08-28 13:17 ` [PATCH v2 3/4] media: sunxi: sun6i-csi: Add support of MIPI CSI-2 for A83T Kévin L'hôpital
2020-08-31 11:26 ` Sakari Ailus
2020-08-28 13:17 ` [PATCH v2 4/4] ARM: dts: sun8i: a83t: Add support for the MIPI CSI-2 in CSI node Kévin L'hôpital
2020-08-28 14:12 ` [PATCH v2 0/4] Support of MIPI CSI-2 for A83T Paul Kocialkowski
2020-08-31 13:04 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200831104847.GJ31019@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=hans.verkuil@cisco.com \
--cc=kevin.lhopital@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab+samsung@kernel.org \
--cc=mripard@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=paul.kocialkowski@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=wens@csie.org \
--cc=yong.deng@magewell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox