public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>
To: Robin Murphy <robin.murphy@arm.com>
Cc: mihail.atanassov@arm.com, liviu.dudau@arm.com,
	dri-devel@lists.freedesktop.org, malidp@foss.arm.com,
	lowry.li@arm.com, nd@arm.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm/komeda: Drop local dma_parms
Date: Mon, 14 Sep 2020 12:41:13 +0800	[thread overview]
Message-ID: <20200914044113.GA1918670@jamwan02-TSP300> (raw)
In-Reply-To: <f7702954-0bea-71c2-b92d-472782203f4b@arm.com>

On Thu, Sep 03, 2020 at 10:26:50PM +0100, Robin Murphy wrote:
> On 2020-09-03 21:36, Robin Murphy wrote:
> > Since commit 9495b7e92f71 ("driver core: platform: Initialize dma_parms
> > for platform devices"), struct platform_device already provides a
> > dma_parms structure, so we can save allocating another one.
> > 
> > Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> > ---
> > 
> > FYI, get_maintainer.pl seems to be choking on your L: entry somehow,
> > since it just shows " (open list:ARM KOMEDA DRM-KMS DRIVER)" without the
> > description or address, not sure what's up with that.
> > 
> >   drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 1 -
> >   drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 2 --
> >   2 files changed, 3 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> > index 1d767473ba8a..e7bb905062d9 100644
> > --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> > @@ -261,7 +261,6 @@ struct komeda_dev *komeda_dev_create(struct device *dev)
> >   		goto disable_clk;
> >   	}
> > 
> > -	dev->dma_parms = &mdev->dma_parms;
> >   	dma_set_max_seg_size(dev, DMA_BIT_MASK(32));
> 
> Oops, I missed my "Also the DMA segment size is simply a size, not a
> bitmask" bit here - ideally this should be changed to UINT_MAX while we're
> cleaning up. Maybe that could just be fixed up when applying, but let me
> know if you'd like a resend.

Don't worry, I can fix it when applying. :)

And thank you for this patch.

Reviewed-by: James Qian Wang <james.qian.wang@arm.com>

> Cheers,
> Robin.
> 
> >   	mdev->iommu = iommu_get_domain_for_dev(mdev->dev);
> > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h
> > index ce27f2f27c24..5b536f0cb548 100644
> > --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h
> > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h
> > @@ -163,8 +163,6 @@ struct komeda_dev {
> >   	struct device *dev;
> >   	/** @reg_base: the base address of komeda io space */
> >   	u32 __iomem   *reg_base;
> > -	/** @dma_parms: the dma parameters of komeda */
> > -	struct device_dma_parameters dma_parms;
> > 
> >   	/** @chip: the basic chip information */
> >   	struct komeda_chip_info chip;
> > --
> > 2.28.0.dirty
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> > 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      reply	other threads:[~2020-09-14  4:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-03 20:36 [PATCH] drm/komeda: Drop local dma_parms Robin Murphy
2020-09-03 21:26 ` Robin Murphy
2020-09-14  4:41   ` james qian wang (Arm Technology China) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200914044113.GA1918670@jamwan02-TSP300 \
    --to=james.qian.wang@arm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=liviu.dudau@arm.com \
    --cc=lowry.li@arm.com \
    --cc=malidp@foss.arm.com \
    --cc=mihail.atanassov@arm.com \
    --cc=nd@arm.com \
    --cc=robin.murphy@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox