From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Leo Yan <leo.yan@linaro.org>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
Peter Zijlstra <peterz@infradead.org>,
John Garry <john.garry@huawei.com>,
linux-kernel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Suleiman Souhlal <suleiman@google.com>,
Namhyung Kim <namhyung@kernel.org>, Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv2] perf kvm: add kvm-stat for arm64
Date: Tue, 15 Sep 2020 19:57:02 +0900 [thread overview]
Message-ID: <20200915105702.GA604@jagdpanzerIV.localdomain> (raw)
In-Reply-To: <20200915103644.GA32758@leoy-ThinkPad-X240s>
Hello,
On (20/09/15 18:36), Leo Yan wrote:
> > +#define HVC_STUB_ERR 0xbadca11
> > +
> > +/* Per asm/kvm_asm.h */
> > +#define ARM_EXCEPTION_IRQ 0
> > +#define ARM_EXCEPTION_EL1_SERROR 1
> > +#define ARM_EXCEPTION_TRAP 2
> > +#define ARM_EXCEPTION_IL 3
>
> Nitpick: from completeness, we also can give out KVM exiting reason
> for 'ARM_EXCEPTION_IL'.
OK, let me take a look.
> > +define_exit_reasons_table(arm64_exit_reasons, kvm_arm_exception_type);
> > +define_exit_reasons_table(arm64_trap_exit_reasons, kvm_arm_exception_class);
> > +
> > +const char *kvm_trap_exit_reason = "esr_ec";
> > +const char *vcpu_id_str = "id";
> > +const int decode_str_len = 20;
> > +const char *kvm_exit_reason = "ret";
> > +const char *kvm_entry_trace = "kvm:kvm_entry";
> > +const char *kvm_exit_trace = "kvm:kvm_exit";
> > +
> > +const char *kvm_events_tp[] = {
> > + "kvm:kvm_entry",
> > + "kvm:kvm_exit",
>
> I think Arm64 needs to support event 'kvm_mmio'. It's good to use a
> new patch for support this event?
Yes, I guess a follow up kvm_mmio patch would be a better option.
> > +int cpu_isa_init(struct perf_kvm_stat *kvm, const char *cpuid __maybe_unused)
> > +{
> > + kvm->exit_reasons = arm64_exit_reasons;
>
> Since the "kvm->exit_reasons" will be always set in the function
> event_get_key(), seems to me here can remove this assignment.
Yes, this assignment is a leftover.
-ss
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-15 11:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 9:11 [PATCHv2] perf kvm: add kvm-stat for arm64 Sergey Senozhatsky
2020-09-15 10:36 ` Leo Yan
2020-09-15 10:57 ` Sergey Senozhatsky [this message]
2020-09-15 11:15 ` Sergey Senozhatsky
2020-09-15 13:21 ` Leo Yan
2020-09-16 0:44 ` Sergey Senozhatsky
2020-09-16 7:51 ` Leo Yan
2020-09-16 8:00 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915105702.GA604@jagdpanzerIV.localdomain \
--to=sergey.senozhatsky@gmail.com \
--cc=john.garry@huawei.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=suleiman@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox