From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Leo Yan <leo.yan@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Peter Zijlstra <peterz@infradead.org>,
John Garry <john.garry@huawei.com>,
linux-kernel@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Suleiman Souhlal <suleiman@google.com>,
Namhyung Kim <namhyung@kernel.org>, Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv3] perf kvm: add kvm-stat for arm64
Date: Thu, 17 Sep 2020 18:54:50 +0900 [thread overview]
Message-ID: <20200917095450.GA3049@jagdpanzerIV.localdomain> (raw)
In-Reply-To: <20200917084744.GB12548@leoy-ThinkPad-X240s>
On (20/09/17 16:47), Leo Yan wrote:
[..]
> > +static void event_get_key(struct evsel *evsel,
> > + struct perf_sample *sample,
> > + struct event_key *key)
> > +{
> > + key->info = 0;
> > + key->key = perf_evsel__intval(evsel, sample, kvm_exit_reason);
>
> Now the perf/core branch doesn't have API perf_evsel__intval(), and it
> has been replaced with evsel__intval(); so please
>
> s/perf_evsel__intval/evsel__intval
ACK.
The kernel I'm using still have perf_evsel__intval().
> > + if (key->key == ARM_EXCEPTION_TRAP) {
> > + key->key = perf_evsel__intval(evsel, sample,
>
> Ditto.
ACK. Sorry about that.
> Otherwise, this patch is good for me and I have tested this patch with
> below commands:
>
> $ perf kvm stat record
> $ perf kvm stat report
"perf kvm stat live" should also work.
> Reviewed-by: Leo Yan <leo.yan@linaro.org>
> Tested-by: Leo Yan <leo.yan@linaro.org>
Thanks!
-ss
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-17 9:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 0:36 [PATCHv3] perf kvm: add kvm-stat for arm64 Sergey Senozhatsky
2020-09-17 8:47 ` Leo Yan
2020-09-17 9:54 ` Sergey Senozhatsky [this message]
2020-09-17 10:09 ` Leo Yan
2020-09-17 10:12 ` Leo Yan
2020-09-17 10:21 ` Marc Zyngier
2020-09-17 11:00 ` Sergey Senozhatsky
2020-09-17 13:08 ` Leo Yan
2020-09-17 11:42 ` Leo Yan
2020-09-17 11:53 ` Marc Zyngier
2020-09-17 12:52 ` Leo Yan
2020-09-18 0:32 ` Sergey Senozhatsky
2020-09-18 8:20 ` Marc Zyngier
2020-09-18 10:35 ` Sergey Senozhatsky
2020-09-18 10:55 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200917095450.GA3049@jagdpanzerIV.localdomain \
--to=sergey.senozhatsky@gmail.com \
--cc=acme@kernel.org \
--cc=john.garry@huawei.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=suleiman@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox