From: Mark Brown <broonie@kernel.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Ard Biesheuvel <ardb@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: stacktrace: Clarify documentation of EL0 entry frame skipping
Date: Thu, 8 Oct 2020 12:14:57 +0100 [thread overview]
Message-ID: <20201008111457.GA6481@sirena.org.uk> (raw)
In-Reply-To: <20201008101558.GA72325@C02TD0UTHF1T.local>
[-- Attachment #1.1: Type: text/plain, Size: 958 bytes --]
On Thu, Oct 08, 2020 at 11:15:58AM +0100, Mark Rutland wrote:
> I reckon we should remove the special case entirely rather than trying
> to shore up the comment here -- the related comment in entry.S is stale
> and misleading, and this will be a mystery to unfamiliar readers anyhow.
That works too, so long as the check isn't really doing anything it can
just be deleted and the comment with it - it's certainly one less weird
special case. So long as all the things relying on it are already gone.
> Does the below patch look ok to you? I suspect the explicit check for the
> terminal case may help with the reliable stacktrace stuff? e.g. we could
> make that return -ENOENT to distinguish a terminal case from a broken
> frame record.
That's almost exactly what I've got in my reliable stacktrace queue,
down to the choice of -ENOENT for reporting the end of an intact stack.
I'll pick this up for my changes if it doesn't get picked up separately.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-10-08 11:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 17:11 [PATCH] arm64: stacktrace: Clarify documentation of EL0 entry frame skipping Mark Brown
2020-10-08 10:15 ` Mark Rutland
2020-10-08 11:14 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201008111457.GA6481@sirena.org.uk \
--to=broonie@kernel.org \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox