From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Qi Liu <liuqi115@huawei.com>
Cc: suzuki.poulose@arm.com, coresight@lists.linaro.org,
linuxarm@huawei.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org
Subject: Re: [PATCH] coresight: Remove unnecessary THIS_MODULE of funnel and replicator driver
Date: Tue, 3 Nov 2020 09:12:27 -0700 [thread overview]
Message-ID: <20201103161227.GA2852321@xps15> (raw)
In-Reply-To: <1604409708-12400-1-git-send-email-liuqi115@huawei.com>
On Tue, Nov 03, 2020 at 09:21:48PM +0800, Qi Liu wrote:
> As THIS_MODULE has been set in platform_driver_register(), so remove it
> from static funnel driver and static replicator driver to avoid set it
> twice.
>
> Signed-off-by: Qi Liu <liuqi115@huawei.com>
> ---
> drivers/hwtracing/coresight/coresight-funnel.c | 2 +-
> drivers/hwtracing/coresight/coresight-replicator.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-funnel.c b/drivers/hwtracing/coresight/coresight-funnel.c
> index af40814..39be46b 100644
> --- a/drivers/hwtracing/coresight/coresight-funnel.c
> +++ b/drivers/hwtracing/coresight/coresight-funnel.c
> @@ -356,7 +356,7 @@ static struct platform_driver static_funnel_driver = {
> .remove = static_funnel_remove,
> .driver = {
> .name = "coresight-static-funnel",
> - .owner = THIS_MODULE,
> + /* THIS_MODULE is taken care of by platform_driver_register() */
> .of_match_table = static_funnel_match,
> .acpi_match_table = ACPI_PTR(static_funnel_ids),
> .pm = &funnel_dev_pm_ops,
> diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c
> index 62afdde..6772f23 100644
> --- a/drivers/hwtracing/coresight/coresight-replicator.c
> +++ b/drivers/hwtracing/coresight/coresight-replicator.c
> @@ -374,7 +374,7 @@ static struct platform_driver static_replicator_driver = {
> .remove = static_replicator_remove,
> .driver = {
> .name = "coresight-static-replicator",
> - .owner = THIS_MODULE,
> + /* THIS_MODULE is taken care of by platform_driver_register() */
I have applied your patch. Next time please version you revisions.
Thanks,
Mathieu
> .of_match_table = of_match_ptr(static_replicator_match),
> .acpi_match_table = ACPI_PTR(static_replicator_acpi_ids),
> .pm = &replicator_dev_pm_ops,
> --
> 2.8.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-11-03 16:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 13:21 [PATCH] coresight: Remove unnecessary THIS_MODULE of funnel and replicator driver Qi Liu
2020-11-03 16:12 ` Mathieu Poirier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103161227.GA2852321@xps15 \
--to=mathieu.poirier@linaro.org \
--cc=coresight@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liuqi115@huawei.com \
--cc=mike.leach@linaro.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox