From: Will Deacon <will@kernel.org>
To: Ross Meikleham <rossmeikleham@gmail.com>
Cc: catalin.marinas@arm.com, trivial@kernel.org, ardb@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: Kconfig RANDOMIZE_MODULE_REGION_FULL correction
Date: Mon, 9 Nov 2020 11:27:06 +0000 [thread overview]
Message-ID: <20201109112705.GC14356@willie-the-truck> (raw)
In-Reply-To: <20201107143119.GA98510@Charon.home>
Hi Ross,
[+Ard]
On Sat, Nov 07, 2020 at 02:31:19PM +0000, Ross Meikleham wrote:
> In the 5.1.5 Kernel RANDOMIZE_MODULE_REGION_FULL was a 4GB window,
> however this was changed to 2GB from 5.1.6
5.1.5 and 5.1.6 are both stable releases, so it's not terribly useful to
talk about them here and you can't really infer much about when the change
was introduced. Please can you refer to the commit instead? I think you
want:
commit b2eed9b58811 ("arm64/kernel: kaslr: reduce module randomization range to 2 GB")
> (see /arch/arm64/kernel/kaslr.c). This updates the
(you can remove the "see ..." part as it's obvious once you refer to the
commit.
> config description for RANDOMIZE_MODULE_REGION_FULL in /arch/arm64/Kconfig
> to reflect this.
There's no need to say "This...". Documentation/process/submitting-patches.rst
has a bit about how to write commit messages, but I suggest changing this
last sentence to:
Fix the stale Kconfig entry for RANDOMIZE_MODULE_REGION_FULL.
> Signed-off-by: Ross Meikleham <RossMeikleham@gmail.com>
> ---
> arch/arm64/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 6d232837cbee..b8fd2c590057 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -1782,11 +1782,11 @@ config RANDOMIZE_BASE
> If unsure, say N.
>
> config RANDOMIZE_MODULE_REGION_FULL
> - bool "Randomize the module region over a 4 GB range"
> + bool "Randomize the module region over a 2 GB range"
> depends on RANDOMIZE_BASE
> default y
> help
> - Randomizes the location of the module region inside a 4 GB window
> + Randomizes the location of the module region inside a 2 GB window
> covering the core kernel. This way, it is less likely for modules
> to leak information about the location of core kernel data structures
> but it does imply that function calls between modules and the core
Patch looks fine. Please send a v2 with the commit message sorted out and I
can queue it as a fix.
Cheers,
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-11-09 11:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-07 14:31 [PATCH] arm64: Kconfig RANDOMIZE_MODULE_REGION_FULL correction Ross Meikleham
2020-11-09 11:27 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201109112705.GC14356@willie-the-truck \
--to=will@kernel.org \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=rossmeikleham@gmail.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox