From: Sudeep Holla <sudeep.holla@arm.com>
To: Cristian Marussi <cristian.marussi@arm.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, james.quinlan@broadcom.com,
Jonathan.Cameron@Huawei.com, lukasz.luba@arm.com
Subject: Re: [PATCH v2 1/1] firmware: arm_scmi: Add SCMI System Power Control driver
Date: Thu, 12 Nov 2020 14:57:44 +0000 [thread overview]
Message-ID: <20201112145744.wwehqweh2aqo7klp@bogus> (raw)
In-Reply-To: <20201026205531.25585-2-cristian.marussi@arm.com>
On Mon, Oct 26, 2020 at 08:55:31PM +0000, Cristian Marussi wrote:
> Add an SCMI System Power control driver to handle platform's requests
> carried by SYSTEM_POWER_STATE_NOTIFIER notifications: such platform
> requested system power state transitions are handled accordingly,
> gracefully or forcefully, depending on the notifications' message flags.
>
> Graceful requests are by default relayed to userspace using the same
> Kernel API used to handle ACPI Shutdown bus events: alternatively, instead,
> a few available module parameters can be used to tunnel instead such
> requests to userspace via signals addressed to CAD pid.
>
> When handling graceful requests, grant userspace processes a maximum
> (configurable) time to perform their duties and then revert to a forceful
> transition, so avoiding completely timing out platform's maximum grace time
> and hitting possible abrupt power-cuts.
>
> Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
> ---
> drivers/firmware/Kconfig | 12 +
> drivers/firmware/arm_scmi/Makefile | 1 +
> .../firmware/arm_scmi/scmi_power_control.c | 387 ++++++++++++++++++
> 3 files changed, 400 insertions(+)
> create mode 100644 drivers/firmware/arm_scmi/scmi_power_control.c
>
[nit] Since you have just one patch, it is generally preferred to place
all the extra non commit messages here after diff stat to have a single
thread of discussion.
Anyways, probably ccing Arnd/Greg/or anyone who has made some feature
changes in this area(e.g. kernel/reboot.c) might help to get some useful
feedback here.
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-11-12 14:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 20:55 [PATCH v2 0/1] SCMI SystemPower Control driver Cristian Marussi
2020-10-26 20:55 ` [PATCH v2 1/1] firmware: arm_scmi: Add SCMI System Power " Cristian Marussi
2020-11-12 14:57 ` Sudeep Holla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201112145744.wwehqweh2aqo7klp@bogus \
--to=sudeep.holla@arm.com \
--cc=Jonathan.Cameron@Huawei.com \
--cc=cristian.marussi@arm.com \
--cc=james.quinlan@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukasz.luba@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox