From: Guenter Roeck <linux@roeck-us.net>
To: Cristian Marussi <cristian.marussi@arm.com>
Cc: linux-hwmon@vger.kernel.org, mikhail.golubev@opensynergy.com,
Igor.Skalkin@opensynergy.com, jbhayana@google.com,
sudeep.holla@arm.com, linux-kernel@vger.kernel.org,
peter.hilber@opensynergy.com,
linux-arm-kernel@lists.infradead.org, james.quinlan@broadcom.com,
Jonathan.Cameron@Huawei.com, egranata@google.com,
lukasz.luba@arm.com
Subject: Re: [PATCH v4 3/6] hwmon: scmi: update hwmon internal scale data type
Date: Sat, 21 Nov 2020 08:59:03 -0800 [thread overview]
Message-ID: <20201121165903.GA111877@roeck-us.net> (raw)
In-Reply-To: <20201119174906.43862-4-cristian.marussi@arm.com>
On Thu, Nov 19, 2020 at 05:49:03PM +0000, Cristian Marussi wrote:
> Use an int to calculate scale values inside scmi_hwmon_scale() to match
> the updated scale data type in struct scmi_sensor_info.
>
> Cc: linux-hwmon@vger.kernel.org
> Cc: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
Acked-by: Guenter Roeck <linux@roeck-us.net>
[ Assuming this will be pushed togesther with the other patches in the series ]
Guenter
> ---
> drivers/hwmon/scmi-hwmon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/scmi-hwmon.c b/drivers/hwmon/scmi-hwmon.c
> index 09ce30cba54b..17d064e58938 100644
> --- a/drivers/hwmon/scmi-hwmon.c
> +++ b/drivers/hwmon/scmi-hwmon.c
> @@ -30,7 +30,7 @@ static inline u64 __pow10(u8 x)
>
> static int scmi_hwmon_scale(const struct scmi_sensor_info *sensor, u64 *value)
> {
> - s8 scale = sensor->scale;
> + int scale = sensor->scale;
> u64 f;
>
> switch (sensor->type) {
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-21 23:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 17:49 [PATCH v4 0/6] SCMIv3.0 Sensor Extensions Cristian Marussi
2020-11-19 17:49 ` [PATCH v4 1/6] firmware: arm_scmi: rework scmi_sensors_protocol_init Cristian Marussi
2020-11-19 17:49 ` [PATCH v4 2/6] firmware: arm_scmi: add SCMIv3.0 Sensors descriptors extensions Cristian Marussi
2020-11-19 17:49 ` [PATCH v4 3/6] hwmon: scmi: update hwmon internal scale data type Cristian Marussi
2020-11-19 17:59 ` Sudeep Holla
2020-11-21 16:59 ` Guenter Roeck [this message]
2020-11-23 10:00 ` Sudeep Holla
2020-11-19 17:49 ` [PATCH v4 4/6] firmware: arm_scmi: add SCMIv3.0 Sensors timestamped reads Cristian Marussi
2020-11-19 17:49 ` [PATCH v4 5/6] firmware: arm_scmi: add SCMIv3.0 Sensor configuration support Cristian Marussi
2020-11-19 17:49 ` [PATCH v4 6/6] firmware: arm_scmi: add SCMIv3.0 Sensor notifications Cristian Marussi
2020-11-23 10:43 ` [PATCH v4 0/6] SCMIv3.0 Sensor Extensions Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201121165903.GA111877@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Igor.Skalkin@opensynergy.com \
--cc=Jonathan.Cameron@Huawei.com \
--cc=cristian.marussi@arm.com \
--cc=egranata@google.com \
--cc=james.quinlan@broadcom.com \
--cc=jbhayana@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=mikhail.golubev@opensynergy.com \
--cc=peter.hilber@opensynergy.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox