From: Mark Rutland <mark.rutland@arm.com>
To: Joey Gouly <joey.gouly@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
nd@arm.com, Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/2] Introduce macros for the offsets to reserved_pg_dir and tramp_pg_dir
Date: Wed, 3 Feb 2021 12:28:29 +0000 [thread overview]
Message-ID: <20210203122829.GE55896@C02TD0UTHF1T.local> (raw)
In-Reply-To: <20210202123658.22308-1-joey.gouly@arm.com>
On Tue, Feb 02, 2021 at 12:36:56PM +0000, Joey Gouly wrote:
> Make the offsets to reserved_pg_dir and tramp_pg_dir less fragile by
> introducing macros that contain their offsets.
>
> Also use these macros to verify the offsets at link time.
I like the idea, the implementation appears to be correct, both patches
build and boot without issue, and if I mess with the offsets I get the
expected warnings. So, for both patches:
Reviewed-by: Mark Rutland <mark.rutland@arm.com>
Tested-by: Mark Rutland <mark.rutland@arm.com>
Mark.
>
> Joey Gouly (2):
> arm64: vmlinux.ld.S: add assertion for reserved_pg_dir offset
> arm64: vmlinux.ld.S: add assertion for tramp_pg_dir offset
>
> arch/arm64/include/asm/asm-uaccess.h | 4 ++--
> arch/arm64/include/asm/memory.h | 12 ++++++++++++
> arch/arm64/include/asm/uaccess.h | 2 +-
> arch/arm64/kernel/entry.S | 4 ++--
> arch/arm64/kernel/vmlinux.lds.S | 8 ++++++++
> 5 files changed, 25 insertions(+), 5 deletions(-)
>
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-03 12:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 12:36 [PATCH 0/2] Introduce macros for the offsets to reserved_pg_dir and tramp_pg_dir Joey Gouly
2021-02-02 12:36 ` [PATCH 1/2] arm64: vmlinux.ld.S: add assertion for reserved_pg_dir offset Joey Gouly
2021-02-02 12:36 ` [PATCH 2/2] arm64: vmlinux.ld.S: add assertion for tramp_pg_dir offset Joey Gouly
2021-02-03 12:28 ` Mark Rutland [this message]
2021-02-03 21:31 ` [PATCH 0/2] Introduce macros for the offsets to reserved_pg_dir and tramp_pg_dir Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210203122829.GE55896@C02TD0UTHF1T.local \
--to=mark.rutland@arm.com \
--cc=catalin.marinas@arm.com \
--cc=joey.gouly@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=nd@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox