From: "Pali Rohár" <pali@kernel.org>
To: kostap@marvell.com
Cc: devicetree@vger.kernel.org, andrew@lunn.ch, jaz@semihalf.com,
gregory.clement@bootlin.com, linux-kernel@vger.kernel.org,
linux@armlinux.org.uk, nadavh@marvell.com, robh+dt@kernel.org,
stefanc@marvell.com, mw@semihalf.com, bpeled@marvell.com,
linux-arm-kernel@lists.infradead.org,
sebastian.hesselbarth@gmail.com
Subject: Re: [PATCH v2 06/12] arm64: dts: marvell: armada-3270-espressobin: add comphy references
Date: Fri, 12 Feb 2021 00:28:42 +0100 [thread overview]
Message-ID: <20210211232842.no4jhvdwh4634cyt@pali> (raw)
In-Reply-To: <20210210140949.32515-7-kostap@marvell.com>
On Wednesday 10 February 2021 16:09:43 kostap@marvell.com wrote:
> From: Grzegorz Jaszczyk <jaz@semihalf.com>
>
> Add "phys" entries pointing to COMPHYs to PCIe and USB3 nodes
>
> Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
> Signed-off-by: Konstantin Porotchkin <kostap@marvell.com>
Hello! This patch is not needed and now does nothing.
> ---
> arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
> index daffe136c523..bbd955909813 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
> @@ -59,6 +59,8 @@
> /* J9 */
> &pcie0 {
> status = "okay";
> + /* Generic PHY, providing serdes lanes */
> + phys = <&comphy1 0>;
In mainline kernel is PCIe PHY already provided in armada-37xx.dtsi:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/marvell/armada-37xx.dtsi#n497
> pinctrl-names = "default";
> pinctrl-0 = <&pcie_reset_pins &pcie_clkreq_pins>;
> reset-gpios = <&gpiosb 3 GPIO_ACTIVE_LOW>;
> @@ -139,6 +141,9 @@
> /* J7 */
> &usb3 {
> status = "okay";
> + /* Generic PHY, providing serdes lanes */
> + phys = <&comphy0 0>;
> + phy-names = "usb";
In mainline kernel is USB 3.0 PHY already provided in armada-37xx.dtsi:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/marvell/armada-37xx.dtsi#n359
> };
>
> /* J8 */
> --
> 2.17.1
>
So final binary espressobin DTB files are same with and without this
patch.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-11 23:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 14:09 [PATCH v2 00/12] Device tree fixes for Armada family kostap
2021-02-10 14:09 ` [PATCH v2 01/12] fix: arm64: dts: replace wrong regulator on ap emmc kostap
2021-02-11 10:52 ` Russell King - ARM Linux admin
2021-02-11 13:57 ` [EXT] " Kostya Porotchkin
2021-02-11 14:02 ` Russell King - ARM Linux admin
2021-02-10 14:09 ` [PATCH v2 02/12] dts: mvebu: Update A8K AP806/AP807 SDHCI settings kostap
2021-02-11 10:42 ` Russell King - ARM Linux admin
2021-02-10 14:09 ` [PATCH v2 03/12] dts: mvebu: Add pin control definitions for SDIO interafce kostap
2021-02-10 14:09 ` [PATCH v2 04/12] fix: dts: a8k: Add CP eMMC regulator and update device parameters kostap
2021-02-10 14:09 ` [PATCH v2 05/12] arm64: dts: marvell: armada-3720-db: add comphy references kostap
2021-02-11 23:31 ` Pali Rohár
2021-02-10 14:09 ` [PATCH v2 06/12] arm64: dts: marvell: armada-3270-espressobin: " kostap
2021-02-11 23:28 ` Pali Rohár [this message]
2021-02-10 14:09 ` [PATCH v2 07/12] fix: ARM64: dts: cp110: Switch to 8-bit ECC NAND setting kostap
2021-02-10 14:09 ` [PATCH v2 08/12] arm64: dts: marvell: armada-3720-db: add eeprom description kostap
2021-02-10 14:09 ` [PATCH v2 09/12] dts: a3700: enable dma coherence kostap
2021-02-10 14:09 ` [PATCH v2 10/12] dts: marvell: add 2 eeprom properties to A8K DB device tree kostap
2021-02-10 14:09 ` [PATCH v2 11/12] dts: marvell: add 2 eeprom properties to A7K " kostap
2021-02-10 14:09 ` [PATCH v2 12/12] arm64: dts: fix the Armada 8040 DB AP SDHCI bus width kostap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210211232842.no4jhvdwh4634cyt@pali \
--to=pali@kernel.org \
--cc=andrew@lunn.ch \
--cc=bpeled@marvell.com \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=jaz@semihalf.com \
--cc=kostap@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=stefanc@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox