From: Will Deacon <will@kernel.org>
To: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Wang Nan <wangnan0@huawei.com>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/1] ARM: hw_breakpoint: Do not directly check the event's overflow_handler hook
Date: Thu, 18 Feb 2021 09:13:35 +0000 [thread overview]
Message-ID: <20210218091334.GB4874@willie-the-truck> (raw)
In-Reply-To: <16641f07-e2fd-f3d0-88de-c4c5deb2ad45@huawei.com>
On Thu, Feb 18, 2021 at 10:03:22AM +0800, Leizhen (ThunderTown) wrote:
>
>
> On 2021/2/12 18:02, Will Deacon wrote:
> > On Sun, Feb 07, 2021 at 06:59:34PM +0800, Zhen Lei wrote:
> >> The commit 1879445dfa7b ("perf/core: Set event's default
> >> ::overflow_handler()") set a default event->overflow_handler in
> >> perf_event_alloc(), and replace the check event->overflow_handler with
> >> is_default_overflow_handler(), but one is missing.
> >>
> >> Currently, the bp->overflow_handler can not be NULL. As a result,
> >> enable_single_step() is always not invoked.
> >>
> >> Fixes: 1879445dfa7b ("perf/core: Set event's default ::overflow_handler()")
> >> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> >> Cc: Wang Nan <wangnan0@huawei.com>
> >> ---
> >> arch/arm/kernel/hw_breakpoint.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/arch/arm/kernel/hw_breakpoint.c b/arch/arm/kernel/hw_breakpoint.c
> >> index 08660ae9dcbce1c..b1423fb130ea4a0 100644
> >> --- a/arch/arm/kernel/hw_breakpoint.c
> >> +++ b/arch/arm/kernel/hw_breakpoint.c
> >> @@ -886,7 +886,7 @@ static void breakpoint_handler(unsigned long unknown, struct pt_regs *regs)
> >> info->trigger = addr;
> >> pr_debug("breakpoint fired: address = 0x%x\n", addr);
> >> perf_bp_event(bp, regs);
> >> - if (!bp->overflow_handler)
> >> + if (is_default_overflow_handler(bp))
> >> enable_single_step(bp, addr);
> >> goto unlock;
> >> }
> >
> > Acked-by: Will Deacon <will@kernel.org>
> >
> > Please can you put this into the patch tracker?
> >
> > https://www.arm.linux.org.uk/developer/patches/
>
> I've added it.
>
> https://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=9064/1
Thanks, although you forgot to add my Ack!
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-18 9:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-07 10:59 [PATCH 1/1] ARM: hw_breakpoint: Do not directly check the event's overflow_handler hook Zhen Lei
2021-02-07 13:05 ` Leizhen (ThunderTown)
2021-02-12 10:02 ` Will Deacon
2021-02-18 2:03 ` Leizhen (ThunderTown)
2021-02-18 9:13 ` Will Deacon [this message]
2021-02-18 10:56 ` Leizhen (ThunderTown)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210218091334.GB4874@willie-the-truck \
--to=will@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=thunder.leizhen@huawei.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox