* Re: [PATCH] Documentation: arm64/acpi : clarify arm64 support of IBFT
2021-03-16 18:50 [PATCH] Documentation: arm64/acpi : clarify arm64 support of IBFT Tom Saeger
@ 2021-03-16 19:46 ` Konrad Rzeszutek Wilk
2021-03-18 10:44 ` Will Deacon
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Konrad Rzeszutek Wilk @ 2021-03-16 19:46 UTC (permalink / raw)
To: Tom Saeger
Cc: linux-doc, Jonathan Corbet, Thomas Tai, Konrad Rzeszutek Wilk,
Catalin Marinas, Will Deacon, Randy Dunlap, Al Stone,
linux-arm-kernel, linux-kernel
On Tue, Mar 16, 2021 at 12:50:41PM -0600, Tom Saeger wrote:
> In commit 94bccc340710 ("iscsi_ibft: make ISCSI_IBFT dependson ACPI instead
> of ISCSI_IBFT_FIND") Kconfig was disentangled to make ISCSI_IBFT selection
> not depend on x86.
>
> Update arm64 acpi documentation, changing IBFT support status from
> "Not Supported" to "Optional".
> Opportunistically re-flow paragraph for changed lines.
>
> Link: https://lore.kernel.org/lkml/1563475054-10680-1-git-send-email-thomas.tai@oracle.com/
>
> Signed-off-by: Tom Saeger <tom.saeger@oracle.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Thank you!
> ---
> Documentation/arm64/acpi_object_usage.rst | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/arm64/acpi_object_usage.rst b/Documentation/arm64/acpi_object_usage.rst
> index 377e9d224db0..0609da73970b 100644
> --- a/Documentation/arm64/acpi_object_usage.rst
> +++ b/Documentation/arm64/acpi_object_usage.rst
> @@ -17,12 +17,12 @@ For ACPI on arm64, tables also fall into the following categories:
>
> - Recommended: BERT, EINJ, ERST, HEST, PCCT, SSDT
>
> - - Optional: BGRT, CPEP, CSRT, DBG2, DRTM, ECDT, FACS, FPDT, IORT,
> - MCHI, MPST, MSCT, NFIT, PMTT, RASF, SBST, SLIT, SPMI, SRAT, STAO,
> - TCPA, TPM2, UEFI, XENV
> + - Optional: BGRT, CPEP, CSRT, DBG2, DRTM, ECDT, FACS, FPDT, IBFT,
> + IORT, MCHI, MPST, MSCT, NFIT, PMTT, RASF, SBST, SLIT, SPMI, SRAT,
> + STAO, TCPA, TPM2, UEFI, XENV
>
> - - Not supported: BOOT, DBGP, DMAR, ETDT, HPET, IBFT, IVRS, LPIT,
> - MSDM, OEMx, PSDT, RSDT, SLIC, WAET, WDAT, WDRT, WPBT
> + - Not supported: BOOT, DBGP, DMAR, ETDT, HPET, IVRS, LPIT, MSDM, OEMx,
> + PSDT, RSDT, SLIC, WAET, WDAT, WDRT, WPBT
>
> ====== ========================================================================
> Table Usage for ARMv8 Linux
> --
> 2.31.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] Documentation: arm64/acpi : clarify arm64 support of IBFT
2021-03-16 18:50 [PATCH] Documentation: arm64/acpi : clarify arm64 support of IBFT Tom Saeger
2021-03-16 19:46 ` Konrad Rzeszutek Wilk
@ 2021-03-18 10:44 ` Will Deacon
2021-03-18 11:29 ` Lorenzo Pieralisi
2021-03-22 11:33 ` Lorenzo Pieralisi
2021-03-22 13:19 ` Will Deacon
3 siblings, 1 reply; 7+ messages in thread
From: Will Deacon @ 2021-03-18 10:44 UTC (permalink / raw)
To: Tom Saeger, lorenzo.pieralisi
Cc: linux-doc, Jonathan Corbet, Thomas Tai, Konrad Rzeszutek Wilk,
Catalin Marinas, Randy Dunlap, Al Stone, linux-arm-kernel,
linux-kernel
[+Lorenzo]
On Tue, Mar 16, 2021 at 12:50:41PM -0600, Tom Saeger wrote:
> In commit 94bccc340710 ("iscsi_ibft: make ISCSI_IBFT dependson ACPI instead
> of ISCSI_IBFT_FIND") Kconfig was disentangled to make ISCSI_IBFT selection
> not depend on x86.
>
> Update arm64 acpi documentation, changing IBFT support status from
> "Not Supported" to "Optional".
> Opportunistically re-flow paragraph for changed lines.
>
> Link: https://lore.kernel.org/lkml/1563475054-10680-1-git-send-email-thomas.tai@oracle.com/
>
> Signed-off-by: Tom Saeger <tom.saeger@oracle.com>
> ---
> Documentation/arm64/acpi_object_usage.rst | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
Lorenzo, please could you ack the change below if you're happy with it?
If so, I can take it as a fix.
Thanks,
Will
> diff --git a/Documentation/arm64/acpi_object_usage.rst b/Documentation/arm64/acpi_object_usage.rst
> index 377e9d224db0..0609da73970b 100644
> --- a/Documentation/arm64/acpi_object_usage.rst
> +++ b/Documentation/arm64/acpi_object_usage.rst
> @@ -17,12 +17,12 @@ For ACPI on arm64, tables also fall into the following categories:
>
> - Recommended: BERT, EINJ, ERST, HEST, PCCT, SSDT
>
> - - Optional: BGRT, CPEP, CSRT, DBG2, DRTM, ECDT, FACS, FPDT, IORT,
> - MCHI, MPST, MSCT, NFIT, PMTT, RASF, SBST, SLIT, SPMI, SRAT, STAO,
> - TCPA, TPM2, UEFI, XENV
> + - Optional: BGRT, CPEP, CSRT, DBG2, DRTM, ECDT, FACS, FPDT, IBFT,
> + IORT, MCHI, MPST, MSCT, NFIT, PMTT, RASF, SBST, SLIT, SPMI, SRAT,
> + STAO, TCPA, TPM2, UEFI, XENV
>
> - - Not supported: BOOT, DBGP, DMAR, ETDT, HPET, IBFT, IVRS, LPIT,
> - MSDM, OEMx, PSDT, RSDT, SLIC, WAET, WDAT, WDRT, WPBT
> + - Not supported: BOOT, DBGP, DMAR, ETDT, HPET, IVRS, LPIT, MSDM, OEMx,
> + PSDT, RSDT, SLIC, WAET, WDAT, WDRT, WPBT
>
> ====== ========================================================================
> Table Usage for ARMv8 Linux
> --
> 2.31.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] Documentation: arm64/acpi : clarify arm64 support of IBFT
2021-03-18 10:44 ` Will Deacon
@ 2021-03-18 11:29 ` Lorenzo Pieralisi
2021-03-18 14:20 ` Ard Biesheuvel
0 siblings, 1 reply; 7+ messages in thread
From: Lorenzo Pieralisi @ 2021-03-18 11:29 UTC (permalink / raw)
To: Will Deacon
Cc: Tom Saeger, linux-doc, Jonathan Corbet, Thomas Tai,
Konrad Rzeszutek Wilk, Catalin Marinas, Randy Dunlap, Al Stone,
linux-arm-kernel, linux-kernel, ahs3, ardb
[+ Al, Ard]
On Thu, Mar 18, 2021 at 10:44:33AM +0000, Will Deacon wrote:
> [+Lorenzo]
>
> On Tue, Mar 16, 2021 at 12:50:41PM -0600, Tom Saeger wrote:
> > In commit 94bccc340710 ("iscsi_ibft: make ISCSI_IBFT dependson ACPI instead
> > of ISCSI_IBFT_FIND") Kconfig was disentangled to make ISCSI_IBFT selection
> > not depend on x86.
> >
> > Update arm64 acpi documentation, changing IBFT support status from
> > "Not Supported" to "Optional".
> > Opportunistically re-flow paragraph for changed lines.
> >
> > Link: https://lore.kernel.org/lkml/1563475054-10680-1-git-send-email-thomas.tai@oracle.com/
> >
> > Signed-off-by: Tom Saeger <tom.saeger@oracle.com>
> > ---
> > Documentation/arm64/acpi_object_usage.rst | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
>
> Lorenzo, please could you ack the change below if you're happy with it?
> If so, I can take it as a fix.
I don't see any issue with this patch, more so given that the IBFT
legacy discovery method was decoupled from the ACPI table method,
so it looks sound on ARM64.
However, I would like to get Al and Ard opinions on this to make sure
there is not something I am missing (in particular wrt the rationale
behind the "Not Supported" in the docs).
Lorenzo
> Thanks,
>
> Will
>
> > diff --git a/Documentation/arm64/acpi_object_usage.rst b/Documentation/arm64/acpi_object_usage.rst
> > index 377e9d224db0..0609da73970b 100644
> > --- a/Documentation/arm64/acpi_object_usage.rst
> > +++ b/Documentation/arm64/acpi_object_usage.rst
> > @@ -17,12 +17,12 @@ For ACPI on arm64, tables also fall into the following categories:
> >
> > - Recommended: BERT, EINJ, ERST, HEST, PCCT, SSDT
> >
> > - - Optional: BGRT, CPEP, CSRT, DBG2, DRTM, ECDT, FACS, FPDT, IORT,
> > - MCHI, MPST, MSCT, NFIT, PMTT, RASF, SBST, SLIT, SPMI, SRAT, STAO,
> > - TCPA, TPM2, UEFI, XENV
> > + - Optional: BGRT, CPEP, CSRT, DBG2, DRTM, ECDT, FACS, FPDT, IBFT,
> > + IORT, MCHI, MPST, MSCT, NFIT, PMTT, RASF, SBST, SLIT, SPMI, SRAT,
> > + STAO, TCPA, TPM2, UEFI, XENV
> >
> > - - Not supported: BOOT, DBGP, DMAR, ETDT, HPET, IBFT, IVRS, LPIT,
> > - MSDM, OEMx, PSDT, RSDT, SLIC, WAET, WDAT, WDRT, WPBT
> > + - Not supported: BOOT, DBGP, DMAR, ETDT, HPET, IVRS, LPIT, MSDM, OEMx,
> > + PSDT, RSDT, SLIC, WAET, WDAT, WDRT, WPBT
> >
> > ====== ========================================================================
> > Table Usage for ARMv8 Linux
> > --
> > 2.31.0
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] Documentation: arm64/acpi : clarify arm64 support of IBFT
2021-03-18 11:29 ` Lorenzo Pieralisi
@ 2021-03-18 14:20 ` Ard Biesheuvel
0 siblings, 0 replies; 7+ messages in thread
From: Ard Biesheuvel @ 2021-03-18 14:20 UTC (permalink / raw)
To: Lorenzo Pieralisi
Cc: Will Deacon, Tom Saeger, Linux Doc Mailing List, Jonathan Corbet,
Thomas Tai, Konrad Rzeszutek Wilk, Catalin Marinas, Randy Dunlap,
Al Stone, Linux ARM, Linux Kernel Mailing List, ahs3
On Thu, 18 Mar 2021 at 12:29, Lorenzo Pieralisi
<lorenzo.pieralisi@arm.com> wrote:
>
> [+ Al, Ard]
>
> On Thu, Mar 18, 2021 at 10:44:33AM +0000, Will Deacon wrote:
> > [+Lorenzo]
> >
> > On Tue, Mar 16, 2021 at 12:50:41PM -0600, Tom Saeger wrote:
> > > In commit 94bccc340710 ("iscsi_ibft: make ISCSI_IBFT dependson ACPI instead
> > > of ISCSI_IBFT_FIND") Kconfig was disentangled to make ISCSI_IBFT selection
> > > not depend on x86.
> > >
> > > Update arm64 acpi documentation, changing IBFT support status from
> > > "Not Supported" to "Optional".
> > > Opportunistically re-flow paragraph for changed lines.
> > >
> > > Link: https://lore.kernel.org/lkml/1563475054-10680-1-git-send-email-thomas.tai@oracle.com/
> > >
> > > Signed-off-by: Tom Saeger <tom.saeger@oracle.com>
> > > ---
> > > Documentation/arm64/acpi_object_usage.rst | 10 +++++-----
> > > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > Lorenzo, please could you ack the change below if you're happy with it?
> > If so, I can take it as a fix.
>
> I don't see any issue with this patch, more so given that the IBFT
> legacy discovery method was decoupled from the ACPI table method,
> so it looks sound on ARM64.
>
> However, I would like to get Al and Ard opinions on this to make sure
> there is not something I am missing (in particular wrt the rationale
> behind the "Not Supported" in the docs).
>
Both the original change and this documentation change look fine to me.
Acked-by: Ard Biesheuvel <ardb@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Documentation: arm64/acpi : clarify arm64 support of IBFT
2021-03-16 18:50 [PATCH] Documentation: arm64/acpi : clarify arm64 support of IBFT Tom Saeger
2021-03-16 19:46 ` Konrad Rzeszutek Wilk
2021-03-18 10:44 ` Will Deacon
@ 2021-03-22 11:33 ` Lorenzo Pieralisi
2021-03-22 13:19 ` Will Deacon
3 siblings, 0 replies; 7+ messages in thread
From: Lorenzo Pieralisi @ 2021-03-22 11:33 UTC (permalink / raw)
To: Tom Saeger
Cc: linux-doc, Jonathan Corbet, Thomas Tai, Konrad Rzeszutek Wilk,
Catalin Marinas, Will Deacon, Randy Dunlap, Al Stone,
linux-arm-kernel, linux-kernel
On Tue, Mar 16, 2021 at 12:50:41PM -0600, Tom Saeger wrote:
> In commit 94bccc340710 ("iscsi_ibft: make ISCSI_IBFT dependson ACPI instead
> of ISCSI_IBFT_FIND") Kconfig was disentangled to make ISCSI_IBFT selection
> not depend on x86.
>
> Update arm64 acpi documentation, changing IBFT support status from
> "Not Supported" to "Optional".
> Opportunistically re-flow paragraph for changed lines.
>
> Link: https://lore.kernel.org/lkml/1563475054-10680-1-git-send-email-thomas.tai@oracle.com/
>
> Signed-off-by: Tom Saeger <tom.saeger@oracle.com>
> ---
> Documentation/arm64/acpi_object_usage.rst | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> diff --git a/Documentation/arm64/acpi_object_usage.rst b/Documentation/arm64/acpi_object_usage.rst
> index 377e9d224db0..0609da73970b 100644
> --- a/Documentation/arm64/acpi_object_usage.rst
> +++ b/Documentation/arm64/acpi_object_usage.rst
> @@ -17,12 +17,12 @@ For ACPI on arm64, tables also fall into the following categories:
>
> - Recommended: BERT, EINJ, ERST, HEST, PCCT, SSDT
>
> - - Optional: BGRT, CPEP, CSRT, DBG2, DRTM, ECDT, FACS, FPDT, IORT,
> - MCHI, MPST, MSCT, NFIT, PMTT, RASF, SBST, SLIT, SPMI, SRAT, STAO,
> - TCPA, TPM2, UEFI, XENV
> + - Optional: BGRT, CPEP, CSRT, DBG2, DRTM, ECDT, FACS, FPDT, IBFT,
> + IORT, MCHI, MPST, MSCT, NFIT, PMTT, RASF, SBST, SLIT, SPMI, SRAT,
> + STAO, TCPA, TPM2, UEFI, XENV
>
> - - Not supported: BOOT, DBGP, DMAR, ETDT, HPET, IBFT, IVRS, LPIT,
> - MSDM, OEMx, PSDT, RSDT, SLIC, WAET, WDAT, WDRT, WPBT
> + - Not supported: BOOT, DBGP, DMAR, ETDT, HPET, IVRS, LPIT, MSDM, OEMx,
> + PSDT, RSDT, SLIC, WAET, WDAT, WDRT, WPBT
>
> ====== ========================================================================
> Table Usage for ARMv8 Linux
> --
> 2.31.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] Documentation: arm64/acpi : clarify arm64 support of IBFT
2021-03-16 18:50 [PATCH] Documentation: arm64/acpi : clarify arm64 support of IBFT Tom Saeger
` (2 preceding siblings ...)
2021-03-22 11:33 ` Lorenzo Pieralisi
@ 2021-03-22 13:19 ` Will Deacon
3 siblings, 0 replies; 7+ messages in thread
From: Will Deacon @ 2021-03-22 13:19 UTC (permalink / raw)
To: Jonathan Corbet, Thomas Tai, Tom Saeger, linux-doc,
Konrad Rzeszutek Wilk
Cc: catalin.marinas, kernel-team, Will Deacon, linux-arm-kernel,
Randy Dunlap, Al Stone, linux-kernel
On Tue, 16 Mar 2021 12:50:41 -0600, Tom Saeger wrote:
> In commit 94bccc340710 ("iscsi_ibft: make ISCSI_IBFT dependson ACPI instead
> of ISCSI_IBFT_FIND") Kconfig was disentangled to make ISCSI_IBFT selection
> not depend on x86.
>
> Update arm64 acpi documentation, changing IBFT support status from
> "Not Supported" to "Optional".
> Opportunistically re-flow paragraph for changed lines.
>
> [...]
Applied to arm64 (for-next/fixes), thanks!
[1/1] Documentation: arm64/acpi : clarify arm64 support of IBFT
https://git.kernel.org/arm64/c/e14a371f732b
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread